Added syntax linter for project#3
Open
wrjac wants to merge 8 commits into
Open
Conversation
This'll make it easier to debug simple syntax issues. Look at https://www.travis-ci.org for more information
Whoops... forgot to add this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is going to make debugging a lot easier with your project... it looks like your build is passing with flying colors right now, but down the line when you're coding more PHP travis-ci will be a lifesaver. If you need any help with this or have an updated PHP build let me know and I can modify the .yml file, but the bash script should always be golden (unless you're wanting to check other file extensions for syntax issues of course)
Also from looking at your code one thing I'd immediately suggest is to clean up your views a bit... that is, separating the header, footer and all of those boilerplates out into their own separate files and referencing them with an "include" statement. Check out this page for more details on how to do so. It will make things a ton easier to debug instead of having to change said boilerplates on each individual file. I can even do this on my end if you want, but I'm not sure how much help you guys are wanting (if at all) on this project... if you are wanting help, though, you can open up some issues on your repo and I'll be glad to see if I can figure them out
(EDIT: the build works on my own branch, but if you get a "permission denied" error on travis-ci let me know... you may need change the permission flags for it on the master branch)