fix: omitNilFormat preserves info on objects with numeric length#146
Merged
fix: omitNilFormat preserves info on objects with numeric length#146
length#146Conversation
Switch omitNilFormat from es-toolkit/compat's omitBy to a hand-rolled
loop. es-toolkit/compat's omitBy treats any object with a numeric
`length` (e.g. a pg error spread via splat) as array-like — it returns
{} and drops winston's LEVEL/MESSAGE symbols, breaking downstream
formats like colorize. Bump to 2.0.1.
Refs toss/es-toolkit#1706.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omitNilFormatwas switched fromlodashtoes-toolkit/compatin v2. Unlike lodash,es-toolkit/compat'somitBytreats any object with a numericlengthproperty as array-like — it iterates0..length-1, returns{}, and drops winston'sLEVEL/MESSAGEsymbols. This breaks downstream formats likecolorizewhenever a pg error is splatted into the log call (pg errors carry a numericlength).omitBycall with a hand-rolled loop overObject.keys+Object.getOwnPropertySymbols— equivalent to the original lodash behaviour and immune to the array-like heuristic.2.0.1.Refs toss/es-toolkit#1706.
Test plan
src/omit-nil-format.spec.ts) feeds aninfoobject with a numericlengthproperty and assertsSymbol.for('level')/Symbol.for('message')survivenpx vitest run src/omit-nil-format.spec.ts— 3/3 passnpx tsc -p tsconfig.json— cleannpx eslint src/omit-nil-format.ts src/omit-nil-format.spec.ts— clean🤖 Generated with Claude Code