Add functions for XML-based input-output tests#116
Draft
flaktack wants to merge 7 commits into
Draft
Conversation
+ fix typings to parse + return None when retreiving unknown entities with version
This allows writing tests that test the XML input-output of transformations.
skinkie
reviewed
Jun 29, 2026
skinkie
reviewed
Jun 30, 2026
| """ | ||
| load_netex(self.storage, frames_xml) | ||
|
|
||
| def read_objects(self, clazz: type[T]) -> list[T]: |
Contributor
There was a problem hiding this comment.
I understand this is a test case. I am torn on creating multiple transactions here.
Author
There was a problem hiding this comment.
Multiple transactions in the sense that each method call creates a new transaction? I can modify the method to reuse a transaction passed in as a parameter.
Contributor
There was a problem hiding this comment.
I also don't like passing transactions around. I foremost want to know why you don't like the context manager approach.
flaktack
force-pushed
the
xml-test-harness
branch
from
495904f to
aa62579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Builds on and includes commits from #115)
This adds a test harness (dc63dae) to allow writing unit tests using simple NeTEx snippets. An example round trip test is included.