fix: update calendar on event notifications - #266
Merged
Conversation
Member
|
Thank you! That's a useful improvement. I'll include it in the new release 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi devs, thanks for such a great module!
This PR just adds one line of code, line 381 below, to MMM-CalendarExt3.js:
This makes it such that, when an eventNotification is received, the calendar refreshes (animates in and out) with the new events.
For my use case, the simplest thing was to make the refresh unconditional: every eventNotification triggers an updateAnimate call, and there's no way to stop it. But, if preferred, I'd be happy to gate the updateAnimate call in some sort of clause. It could be a config parameter that the user sets, or a parameter that's passed as part of the notification payload. In either case, we could preserve the existing default behavior if that is preferable.