feat: migrate to API 15 and implement ViewMatrix targeting#31
Open
Matuno wants to merge 1 commit into
Open
Conversation
- Updated to Dalamud API 15 and .NET 10. - Resolved service warnings in Plugin.cs by properly initializing IFramework and IPluginLog. - Refactored targeting to use engine-native ViewMatrix projection. The previous targeting logic relied on the mini-map cone rotation (AreaMapNumberArray), which was offset from the actual scene camera and required fragile 'magic number' corrections (+135 deg). The new system projects targets directly into camera-space using the game's internal ViewMatrix. This provides 100% accurate horizontal targeting by checking the target's position relative to the camera's local axes, eliminating all world-space rotation offsets and coordinate mapping issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heya MKhayle,
I'm a little hesitant to offer this as a PR since the whole thing is AI generated, but with my guidance and debugging. During the moment of the broken build last night I gave it a look-over and did a debugging run with in-world values and this system... checks out.. accurately.
It might give some insights so I'm sharing it for that, but otherwise just feel free to ignore this. Didn't want it to go straight to trash,
The previous targeting logic relied on the mini-map cone rotation (AreaMapNumberArray), which was offset from the actual scene camera and required fragile 'magic number' corrections (+135 deg).
The new system projects targets directly into camera-space using the game's internal ViewMatrix. This provides 100% accurate horizontal targeting by checking the target's position relative to the camera's local axes, eliminating all world-space rotation offsets and coordinate mapping issues.