Devel/toggle annotation z visibility - #358
Open
joakimlindblad wants to merge 8 commits into
Open
Conversation
…g to work properly
… not visible across z-layers to match the visual behavior of markers
Olleesch
reviewed
Aug 5, 2026
Olleesch
left a comment
Olleesch
left a comment
Member
There was a problem hiding this comment.
Found one bug where z is not tracked on marker updates, which breaks the marker z-culling. Also made region annotations disappear instantly instead of fading when switching z and annotations are not visible across z-layers to match the visual behavior of markers now with z-culling. See last two commits. Other than that, everything looks good to me!
Two more thoughts:
- The new duration time in exit marker looks instantaneous to me with only a few markers, maybe too steep of a drop off?
- Region culling would probably be useful to add at some point to improve scaling with the number of region annotations (+ would then handle z-culling the same way as for markers).
…ed with z-level culling. Now separating 2D-cull and z-cull (so 2D-recompute not done if just changing z). Not storing z in markerItem data (only in the actual marker object).
…ck&forth z-changes, for zVisibility=false
joakimlindblad
force-pushed
the
devel/toggle_annotation_z_visibility
branch
from
August 15, 2026 15:26
a57950a to
c2f9cae
Compare
Member
Author
|
Member
Author
|
See also #362 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch whether annotations should be visible in all or only current z-layer.
Relying on same code as cullMarkers() makes it smooth for 100k markers.