V2.1 improvements - #11
Merged
Merged
Conversation
…debugging and error tracking
NOTE: since udocker is a) significantly slower and b) wasn't widely used, I refactored the code focusing on Docker as single backend. This reduces the complexity (no multi-backend) and allowed to simplify and streamline the code and eventually leading to a more robust implementation. We can always re-evaluate the integration of multiple backends, adding udocker support and potential other alternatives. However, such an investment should be driven by a real use-case / need and not be soley experimental.
… icons for disabled state
… in model details
…in sections are collapsed
…icons for MHubRunner
… setup button, set default width
- Modality selector is enabled for files not referenced in the DICOM store - Before running, we convert the image into DICOM using Slicer's export functionality NOTE: we skip adding the segmentations back into the DICOM store for non-dicom instances.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements significant improvements to the MHubRunner extension for 3D Slicer, focusing on UI/UX enhancements, Docker integration, and expanded functionality. The changes remove udocker support to simplify the codebase and focus solely on Docker as the backend, add a new Docker setup screen, move advanced settings to a separate dialog, and introduce support for non-DICOM files with modality selection.
Changes:
- Added Docker setup screen for first-time users when Docker is not detected
- Moved Backend, GPU, and Advanced settings to a separate Settings dialog, with a static summary displayed in the main UI
- Removed udocker backend support entirely, simplifying code by eliminating backend parameter throughout
- Added licensing information display (model/weights licenses and commercial use indicators)
- Introduced support for non-DICOM volumes with modality selection and DICOM export capability
- Added new icon resources for UI buttons with theme-aware rendering (dark/light mode)
- Implemented async model fetching with status hydration to improve UI responsiveness
- Enhanced output file management with Open button and format filtering
Reviewed changes
Copilot reviewed 5 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| MHubRunner/Resources/UI/MHubRunnerSettings.ui | New settings dialog UI with MHub.ai information, GPU, Docker, Advanced, and Log sections |
| MHubRunner/Resources/UI/MHubRunner.ui | Restructured main UI with stacked widget for Docker setup screen, added modality selector and output file controls |
| MHubRunner/Resources/Icons/*.png | New icon assets for buttons (pull, play, cancel, info, settings, show) in both light and dark theme variants |
| MHubRunner/MHubRunner.py | Major refactoring: removed udocker code, added async fetching, licensing logic, non-DICOM support, settings dialog, debouncer/poller utilities |
| MHubRunner/CMakeLists.txt | Updated resource list to include all new icon files and the settings UI file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some huge, long-planned updates to the V2 extension: