Skip to content

fix: Fix discussion edit form Save not submitting - #23

Open
VedantMadane wants to merge 1 commit into
MAY55A:devfrom
VedantMadane:fix/issue-22
Open

fix: Fix discussion edit form Save not submitting#23
VedantMadane wants to merge 1 commit into
MAY55A:devfrom
VedantMadane:fix/issue-22

Conversation

@VedantMadane

Copy link
Copy Markdown

Summary

Fix discussion edit form Save not submitting

Changes

  • src\components\project-creation\task-field-setup.tsx: Save changes is submit

Fixes #22

@MAY55A MAY55A left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VedantMadane, thank you for taking this issue!

However, you seem to have updated the wrong component: you updated the task-field-setup component in the project creation form, which is unrelated to the affected component in discussion-form-dialog.tsx.

Please check again the issue description to understand the problem and the affected components.

@VedantMadane

Copy link
Copy Markdown
Author

Thank you for the catch! I have reverted ask-field-setup.tsx and implemented the fix in discussion-form-dialog.tsx: resetting the form state when the dialog opens or discussion data changes, binding data.id and data.creator into updateDiscussion({ ...data, ...formData }), and ensuring Select syncs with ield.value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Discussion edit form submit button does not trigger submission

2 participants