fix: Fix discussion edit form Save not submitting - #23
Open
VedantMadane wants to merge 1 commit into
Open
Conversation
MAY55A
requested changes
Aug 25, 2026
MAY55A
left a comment
Owner
There was a problem hiding this comment.
Hi @VedantMadane, thank you for taking this issue!
However, you seem to have updated the wrong component: you updated the task-field-setup component in the project creation form, which is unrelated to the affected component in discussion-form-dialog.tsx.
Please check again the issue description to understand the problem and the affected components.
VedantMadane
force-pushed
the
fix/issue-22
branch
from
September 3, 2026 04:08
f90afab to
6b55514
Compare
Author
|
Thank you for the catch! I have reverted ask-field-setup.tsx and implemented the fix in discussion-form-dialog.tsx: resetting the form state when the dialog opens or discussion data changes, binding data.id and data.creator into updateDiscussion({ ...data, ...formData }), and ensuring Select syncs with ield.value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix discussion edit form Save not submitting
Changes
Fixes #22