Fix/4060 download button

[LucyChyzhova]

fix: #4070

Summary by CodeRabbit

Bug Fixes

• Prevented duplicate download buttons from appearing in the file viewer when fallback content is displayed
• Adjusted button positioning for improved layout alignment

Review:

• Commits are atomic
• Commits have the correct type for the changes made
• Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

• Chrome
• Edge
• Firefox

Linux:

• Chrome
• Firefox

macOS:

• Chrome
• Firefox
• Safari

Mobile:

• Chrome on Android
• iOS

[coderabbitai]

📝 Walkthrough

Walkthrough

limel-file-viewer fixes two issues: duplicate download buttons in unsupported-filetype fallback UI and overlapping button bar positioning. renderNoFileSupportMessage gains an optional withDownloadButton flag; renderText and renderEmail pass false to suppress the inline download when a toolbar is already present. The .buttons CSS positioning switches from top to bottom.

Changes

file-viewer duplicate download and button positioning fixes

Layer / File(s)	Summary
renderNoFileSupportMessage conditional download button src/components/file-viewer/file-viewer.tsx	renderNoFileSupportMessage accepts an optional withDownloadButton parameter (default true) and guards the download button behind it. renderText passes false to suppress the button; renderEmail wraps its fallback in a <div slot="fallback"> and also passes false.
.buttons vertical positioning src/components/file-viewer/partial-styles/ui-controls.scss	The .buttons bar's vertical anchor is changed from top: 0.25rem to bottom: 0.25rem, moving the toolbar to the bottom-right to avoid collisions with consumer-placed top-right controls.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Lundalogik/lime-elements#3686: Modifies the same renderNoFileSupportMessage fallback UI in file-viewer.tsx, adjusting download/open messaging composition.
• Lundalogik/lime-elements#3910: Also changes renderEmail's fallback slot behavior in file-viewer.tsx.

Suggested reviewers

• Kiarokh
• FredrikWallstrom

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title references issue #4060, but the PR is actually addressing issue #4070. This is misleading, as the title does not accurately reflect the actual issue being fixed.	Update the PR title to reference issue #4070, such as 'Fix #4070: avoid overlapping buttons and duplicate download button' or similar.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR successfully addresses both problems identified in issue #4070: preventing duplicate download buttons in unsupported file fallbacks and repositioning toolbar buttons to avoid overlaps.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the two problems identified in issue #4070; no out-of-scope modifications detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/4060-download-button

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-4145/

[LucyChyzhova]

The PR title references issue #4060, but the PR is actually addressing issue #4070. This is misleading, as the title does not accurately reflect the actual issue being fixed.

yeah, missed the number , should be 4070 instead...