chore(deps): update dependencies#4099
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR updates the development environment by bumping dependency versions across the tooling ecosystem, adapting build scripts to the updated replace-in-file API, adding test environment compatibility shims for mock-doc limitations, and reformatting type definitions. ChangesDevelopment Environment Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-4099/ |
adrianschmidt
force-pushed
the
update-dependencies
branch
from
ef94f2f to
9362dc3
Compare
adrianschmidt
force-pushed
the
update-dependencies
branch
from
9362dc3 to
5c22bcf
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Around line 73-74: The packages `diff` and `sortablejs` are currently listed
only in `devDependencies` but are imported in shipped runtime code files:
`src/components/form/templates/array-field.ts` (sortablejs),
`src/components/code-diff/diff-engine.ts` (diff), and
`src/components/drag-handle/examples/drag-handle-horizontal.tsx` (sortablejs).
Move both `diff` and `sortablejs` entries from the `devDependencies` section to
the `dependencies` section in package.json to ensure consumers of this package
receive these required modules when installing, preventing runtime import
failures.
In `@vitest-setup-browser.ts`:
- Around line 20-23: The URL extraction logic in the globalThis.fetch function
does not properly handle Request objects. Currently, when a Request object is
passed as the input parameter, calling toString() on it returns "[object
Request]" instead of the actual URL. Fix this by checking if the input is a
Request object first and extracting its url property before handling the string
case. Update the URL extraction logic to use the pattern: if input is a Request,
use input.url; otherwise if input is a string, use it directly; otherwise call
toString() on the URL object.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 9658fb1f-6490-407a-8547-c7970b3e352f
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
package.jsonpublish-docs.cjssrc/components/form/form.types.tsvitest-setup-browser.tsvitest-setup.ts
adrianschmidt
force-pushed
the
update-dependencies
branch
from
5c22bcf to
ef2ceb9
Compare
We use tree-shaking, so all dependencies are built-in anyway.
Bump dependencies to current versions within a moderate-risk scope: - @rjsf/*, @stencil/core, @microsoft/api-extractor and all @types/* - cross-env 7 -> 10, diff 8 -> 9, eslint 9.34 -> 9.39 - dayjs, postal-mime, prettier 3.5 -> 3.8, prosemirror-*, react/react-dom 19.1 -> 19.2, sortablejs, style-to-object, tabulator-tables prosemirror-model is deduped to 1.25.7. The changes in form.types.ts and vitest-setup-browser.ts are prettier 3.8 reformatting only. @rollup/plugin-node-resolve is intentionally held at 13.x: v16 changes module resolution in a way that breaks Stencil's CommonJS parsing of @rjsf during the build.
adrianschmidt
force-pushed
the
update-dependencies
branch
from
6130344 to
ecbbd2f
Compare
Collaborator
|
🎉 This PR is included in version 39.34.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Dependency refresh within a moderate-risk scope (safe minor/patch +
low-risk majors; high-risk majors deferred).
Bumped
@rjsf/*,@stencil/core,@microsoft/api-extractor, all@types/*cross-env7 → 10,diff8 → 9 (diffLines/diffWordsAPIunchanged),
eslint9.34 → 9.39dayjs,postal-mime,prettier3.5 → 3.8,prosemirror-*(model deduped to 1.25.7),
react/react-dom19.1 → 19.2,sortablejs,style-to-object,tabulator-tablesform.types.ts/vitest-setup-browser.tschanges are prettier 3.8reformatting only.
Deferred (with reasons)
@rollup/plugin-node-resolve13 → 16: v16's module resolutionbreaks Stencil's CommonJS parsing of
@rjsfat build time (isolatedand confirmed). Held at 13.x.
has
/* eslint-env */comments that become errors in v10.@commitlint/config-conventional 19 → 20: high-risk / low-value majors
for a separate effort. (TS 4.9 → 5.x is a good standalone follow-up.)
Note on the fsevents/glob warnings
Those originate from the currently-published
kompendium@1.1.1. Theyare fixed in jgroth/kompendium#183; once that releases, bumping
kompendiumhere will clear them.Verification
npm run build×2 andnpm run lint(0 warnings) green. Full testsuite: 1332 passed, with 19 failures that are pre-existing — a
clean-baseline run (changes stashed,
npm ci) reproduces the identical19 failures (local-env
MutationObserver/PDF-fixture issues, unrelatedto these bumps).
🤖 Generated with Claude Code
Summary by CodeRabbit
HTMLElementhandling, providing an input validity shim, and mockingMutationObserver.