Fix incompatibility issue with Boze - #151
Open
sonhoang780 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Client crashes on startup when TrollHack runs alongside Boze:
Root cause
MixinGameRenderer(targetingGameRenderer) had no explicitpriority, so itfell back to the config-level default (
2100000000introllhack.mixins.json)-- applied essentially last among all mixins. Boze's own loader transforms
GameRenderer.renderLevelearlier (lower/default priority), restructuring themethod before TrollHack's
@Redirectscans it -- by the time it runs, theliteral
Mth.lerp(FFF)Fcall site it targets no longer exists in that exactform, so injection finds 0 targets and mixin throws. Verified via javap against
MC 26.1.2's real
GameRendererbytecode: the method + lerp call do existunmodified -- this isn't a wrong signature, it's an apply-order conflict.
Fix
@Mixin(value = GameRenderer.class, priority = 500)-- apply beforethird-party mods with default/higher priority mutate the target method.
require = 0on the@Redirectas a safety net, so a similar conflict withsome other mod degrades (feature silently no-ops) instead of crashing the
whole client.
Testing
:fabric:compileJavapasses.