fix(ci): clear Terraform stub command on keeper ECS deploy#24
Merged
Conversation
Deploy was swapping the GHCR image but keeping the bedrock stub `command` (busybox sleep), so /health never came up. Drop command and entryPoint so the image CMD runs the real keeper process. Co-authored-by: Cursor <cursoragent@cursor.com>
Exec-form CMD must pass --import and script as separate argv entries. A single combined flag made Node resolve amaro/strip --conditions=typescript and exit with ERR_PACKAGE_PATH_NOT_EXPORTED on ECS. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes keeper failing to stay up on dev ECS after deploy:
Deploy workflow — Strip Terraform stub
command/entryPointwhen registering the task definition so the imageCMDruns (was:sleep infinity+ stub echo → ALB/healthfailed).Dockerfile — Split exec-form
CMDso--import=amaro/stripis its own argv (was one combined string →ERR_PACKAGE_PATH_NOT_EXPORTEDand exit code 1 on task0cb5565749a449478e506763876802b9).Files:
.github/workflows/deploy-keeper.ymlkeeper/DockerfileAfter merge
dev(new image + task def).svc-col-mar-keeper-dev(--profile titanio-dev).https://keeper.dev.hashpower.exchange/healthshould pass.Test plan
dev