fix(hip): restrict wavefront guard to device pass - #628
Open
pepuscz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restrict the rocWMMA wavefront-size compile-time check to the HIP device pass.
Some ROCm 7.1 host passes expose
__AMDGCN_WAVEFRONT_SIZEwithout making it an integer constant expression. Evaluating it in a preprocessor arithmetic condition then rejects an otherwise valid gfx1151 build. The device pass still performs the existing wave32 safety check, so wave64 targets continue to fail loudly.Published qualification patch:
lucebox-rocm71-host-wavefront.patchValidation
git diff --check