Skip to content

fix(hip): restrict wavefront guard to device pass - #628

Open
pepuscz wants to merge 1 commit into
Luce-Org:mainfrom
pepuscz:fix/hip-device-wavefront-guard
Open

fix(hip): restrict wavefront guard to device pass#628
pepuscz wants to merge 1 commit into
Luce-Org:mainfrom
pepuscz:fix/hip-device-wavefront-guard

Conversation

@pepuscz

@pepuscz pepuscz commented Aug 18, 2026

Copy link
Copy Markdown

Summary

Restrict the rocWMMA wavefront-size compile-time check to the HIP device pass.

Some ROCm 7.1 host passes expose __AMDGCN_WAVEFRONT_SIZE without making it an integer constant expression. Evaluating it in a preprocessor arithmetic condition then rejects an otherwise valid gfx1151 build. The device pass still performs the existing wave32 safety check, so wave64 targets continue to fail loudly.

Published qualification patch: lucebox-rocm71-host-wavefront.patch

Validation

  • git diff --check
  • ROCm 7.1.1 / gfx1151 qualified build completed with this guard
  • The patch changes only preprocessor scope; kernel code and device-pass validation are unchanged

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant