feat(lucebox): hub CLI + autotune/sweep/profile + harness adapters + shell wrapper#335
Open
easel wants to merge 1 commit into
Open
feat(lucebox): hub CLI + autotune/sweep/profile + harness adapters + shell wrapper#335easel wants to merge 1 commit into
easel wants to merge 1 commit into
Conversation
91276a7 to
62b21f0
Compare
easel
added a commit
to easel/lucebox-hub
that referenced
this pull request
Jun 4, 2026
## What Containerization stack for lucebox-hub. Dockerfile + docker-bake.hcl build the lucebox-hub image (build-env and runtime stages); scripts/build_image.sh drives local builds; server/scripts/entrypoint.sh emits IMAGE_INFO / HOST_INFO sidecars consumed by /props. GitHub Actions add .github/workflows/docker.yml (build & publish), update ci.yml, and add release-luce-bench.yml for tagging. Workspace-root files (pyproject.toml, uv.lock, Makefile, lefthook.yml, .gitignore, README) live here because the Dockerfile uv-syncs the workspace at build time. ## Why Provides the reproducible image and CI pipeline every other split PR deploys into. Centralizing build/publish here keeps Dockerfile, entrypoint, and workspace-root pinning in one reviewable change. ## Dependencies - Luce-Org#335 (lucebox-cli): Dockerfile COPYs lucebox/ into the image - Luce-Org#337 (lucebench-harness): Dockerfile COPYs luce-bench/ into the image
easel
added a commit
to easel/lucebox-hub
that referenced
this pull request
Jun 4, 2026
## What Containerization stack for lucebox-hub. Dockerfile + docker-bake.hcl build the lucebox-hub image (build-env and runtime stages); scripts/build_image.sh drives local builds; server/scripts/entrypoint.sh emits IMAGE_INFO / HOST_INFO sidecars consumed by /props. GitHub Actions add .github/workflows/docker.yml (build & publish), update ci.yml, and add release-luce-bench.yml for tagging. Workspace-root files (pyproject.toml, uv.lock, Makefile, lefthook.yml, .gitignore, README) live here because the Dockerfile uv-syncs the workspace at build time. ## Why Provides the reproducible image and CI pipeline every other split PR deploys into. Centralizing build/publish here keeps Dockerfile, entrypoint, and workspace-root pinning in one reviewable change. ## Dependencies - Luce-Org#335 (lucebox-cli): Dockerfile COPYs lucebox/ into the image - Luce-Org#337 (lucebench-harness): Dockerfile COPYs luce-bench/ into the image
6c9078b to
360d332
Compare
easel
added a commit
to easel/lucebox-hub
that referenced
this pull request
Jun 4, 2026
## What Containerization stack for lucebox-hub. Dockerfile + docker-bake.hcl build the lucebox-hub image (build-env and runtime stages); scripts/build_image.sh drives local builds; server/scripts/entrypoint.sh emits IMAGE_INFO / HOST_INFO sidecars consumed by /props. GitHub Actions add .github/workflows/docker.yml (build & publish), update ci.yml, and add release-luce-bench.yml for tagging. Workspace-root files (pyproject.toml, uv.lock, Makefile, lefthook.yml, .gitignore, README) live here because the Dockerfile uv-syncs the workspace at build time. ## Why Provides the reproducible image and CI pipeline every other split PR deploys into. Centralizing build/publish here keeps Dockerfile, entrypoint, and workspace-root pinning in one reviewable change. ## Dependencies - Luce-Org#335 (lucebox-cli): Dockerfile COPYs lucebox/ into the image - Luce-Org#337 (lucebench-harness): Dockerfile COPYs luce-bench/ into the image
1d588db to
0d8e1ff
Compare
Contributor
There was a problem hiding this comment.
29 issues found across 52 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="lucebox/src/lucebox/docker_run.py">
<violation number="1" location="lucebox/src/lucebox/docker_run.py:231">
P3: Several newly added helper functions are dead code (defined but never called anywhere in the codebase).</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| # ── subprocess helpers ───────────────────────────────────────────────────── | ||
|
|
||
|
|
||
| def run(argv: list[str], *, check: bool = True) -> subprocess.CompletedProcess[str]: |
Contributor
There was a problem hiding this comment.
P3: Several newly added helper functions are dead code (defined but never called anywhere in the codebase).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At lucebox/src/lucebox/docker_run.py, line 231:
<comment>Several newly added helper functions are dead code (defined but never called anywhere in the codebase).</comment>
<file context>
@@ -0,0 +1,270 @@
+# ── subprocess helpers ─────────────────────────────────────────────────────
+
+
+def run(argv: list[str], *, check: bool = True) -> subprocess.CompletedProcess[str]:
+ """Run a command, streaming stdout/stderr to the user. `check=False` to
+ inspect exit codes manually."""
</file context>
Collaborator
Author
There was a problem hiding this comment.
Fixed in 73f04f4: removed the unused run(), docker_inspect_running(), host_path_visible(), and stderr() helpers from docker_run.py, plus the now-unused sys import.
Contributor
There was a problem hiding this comment.
Thanks for the update!
easel
pushed a commit
to easel/lucebox-hub
that referenced
this pull request
Jun 5, 2026
… adapters ## What New lucebox/ Python package exposing the hub CLI (autotune, sweep, profile, smoke, models, config, download, host-check, docker_run) plus the lucebox.sh launcher wrapper and install.sh. Adds the harness/ adapter package wrapping external coding agents (claude_code, codex, hermes, openclaw, opencode, pi) that autotune sweeps drive. Ships scripts/check_lucebox_wrapper_sandbox.sh and scripts/test_lucebox_sh.sh for wrapper validation, full pytest coverage under lucebox/tests/, and the bragi autotune profile-sweep protocol docs. ## Why This is the user-facing surface of lucebox-hub: one CLI to launch the image, tune layer-split / pflash settings against a host, run sweeps, and dispatch bench runs. Splitting it out keeps Python-side review independent of the C++ server and Docker stack reviews. ## Dependencies - Luce-Org#334 (docker-stack): docker_run.py launches the lucebox-hub image - Luce-Org#337 (lucebench-harness): lucebox bench delegates to luce-bench (workspace dep) - Luce-Org#336 (server-layer-split): autotune presumes layer-split build artifacts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
luceboxhub CLI (autotune, sweep, profile, smoke, models, config, download, host-check, docker_run) plus thelucebox.shwrapper andinstall.shbootstrap. Also lands theharness/adapter package (claude_code, codex, hermes, openclaw, opencode, pi) and therun_lucebench.shshim thatlucebox bench-style flows shell out to. Additive only — no existing source files modified outside CI workflow edits, README touch-ups, and alefthook.ymlfor the new packages.Files
lucebox/— new Python package: CLI entrypoint, autotune/sweep/profile/smoke/config/download/host-check/docker_run modules, full pytest suite underlucebox/tests/.harness/— new Python package:harness.bench+ per-agent client adapters (claude_code.py,codex.py,hermes.py,openclaw.py,opencode.py,pi.py) and therun_lucebench.shoperator shim.lucebox.sh+install.sh— top-level shell wrapper and bootstrap installer.scripts/check_lucebox_wrapper_sandbox.sh,scripts/test_lucebox_sh.sh— wrapper-shape integration tests..github/workflows/ci.yml— wires the new packages into CI.harness/clients/README.md,lefthook.yml— supporting docs/config.Single commit, ~10.5k LOC added across 49 files.
Dependencies
lucebox.docker_runshells out todocker runagainst thelucebox-hubimage and reads theIMAGE_INFOproduced by the docker build. The CLI cannot exercise a real run path until docker-stack lands.harness/bench.pyinvokespython -m lucebench.cli ...as a subprocess;harness/clients/run_lucebench.shis the operator shim around the same package. Both require the lucebench package to be importable.Unit tests in
lucebox/tests/andharness/mock the external surfaces and pass standalone, but end-to-end validation requires the three siblings above.Test plan
cd lucebox && uv run pytest(standalone — mocks docker/lucebench surfaces)cd harness && uv run pytest(standalone)./lucebox.sh --helpresolves once build(docker): lucebox-hub container image + CI release pipeline #334 lands and the image is availablelucebox host-checkreports GPU + driver facts on a fresh hostlucebox autotune --dry-runenumerates candidate configs without launching a sweeplucebox bench-style flow once feat(luce-bench): in-tree bench harness + multi-turn agent_recorded + LLM judge #337 (luce-bench) is mergeable and refactor(server): shared layer-split backend + GGUF inspection + c2-gate plumbing #336 (server layer-split) is exposing the expected build flagsNote: this PR's CLI/adapter code is self-contained and unit-tests pass standalone, but full integration validation requires the docker, luce-bench, and server-layer-split siblings to land together.
Generated with Claude Code