Skip to content

fix(cli): preserve literal fill arguments - #95

Merged
yashranaway merged 1 commit into
mainfrom
t3code/fill-end-of-options
Aug 10, 2026
Merged

fix(cli): preserve literal fill arguments#95
yashranaway merged 1 commit into
mainfrom
t3code/fill-end-of-options

Conversation

@yashranaway

Copy link
Copy Markdown
Collaborator

Closes #17.

What changed

  • Recognize global --json and --session only before the first -- sentinel.
  • Remove the sentinel before command parsing so literal flag-looking values reach fill unchanged.
  • Require fill text as one shell argument instead of joining tokens and normalizing whitespace.
  • Document the CLI contract in architecture decision 16, help text, and the agent skill.
  • Mark backlog A6 complete and add the unreleased changelog entry.

Regression coverage

The protocol suite now checks:

  • global options before the sentinel still work;
  • literal --json and --session values after the sentinel survive;
  • tabs and double spaces are preserved exactly;
  • unquoted multi-token fill text is rejected instead of silently normalized.

Verification

  • Protocol/security suite in swift:6.1-bookworm: 31/31 passed.
  • pnpm test:runtime: passed.
  • git diff --check: passed.

The host and wire protocol are unchanged, so no platform E2E label is required.

@yashranaway
yashranaway merged commit ff153c3 into main Aug 10, 2026
7 checks passed
@yashranaway
yashranaway deleted the t3code/fill-end-of-options branch August 10, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A6 — --json/--session stripped from anywhere in argv

1 participant