Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions apps/headless/LinuxHost/main.swift
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,12 @@ final class LinuxBrowserHost: @unchecked Sendable {
case .networkMockSet: result = try session.setNetworkMock(parameters: request.parameters)
case .networkMockClear: result = try session.clearNetworkMocks()
case .visualCompare:
let before = request.parameters["before"]!.stringValue!
let after = request.parameters["after"]!.stringValue!
guard let before = request.parameters["before"]?.stringValue else {
return failure(request, "MISSING_PARAMETER", "Before artifact name is required.")
}
guard let after = request.parameters["after"]?.stringValue else {
return failure(request, "MISSING_PARAMETER", "After artifact name is required.")
}
_ = try artifacts.read(name: before, expectedExtension: "png", maximumBytes: 100 * 1_024 * 1_024)
_ = try artifacts.read(name: after, expectedExtension: "png", maximumBytes: 100 * 1_024 * 1_024)
let difference = try artifacts.reserve(requestedName: request.parameters["output"]?.stringValue,
Expand Down
2 changes: 1 addition & 1 deletion apps/headless/Sources/HeadlessProtocol/Diagnostics.swift
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public final class QADiagnosticStore: @unchecked Sendable {
issue["suggestion"] = .string(suggestion)
if let url { issue["url"] = .string(url) }
if let status { issue["status"] = .number(status) }
if object["method"] != nil { issue["method"] = object["method"]! }
if let method = object["method"] { issue["method"] = method }
if url != nil { issue["local"] = .bool(local) }
return .object(issue)
}
Expand Down
17 changes: 17 additions & 0 deletions apps/headless/Tests/HeadlessProtocolTests/ProtocolTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,23 @@ struct ProtocolTests {
static func cliP2CommandsAndBoundaries() throws {
let visual = try CLIParser().parse(["visual", "compare", "before.png", "after.png", "--output", "diff.png"])
try expect(visual.request?.command == .visualCompare, "visual compare should parse")
// Both hosts read these two names to locate the artifacts to diff. They
// guard the lookup and answer MISSING_PARAMETER, but the validator is
// what keeps a malformed request from reaching that path at all — if it
// ever stopped requiring them, the guards would be the only thing
// standing between a crafted request and a broken comparison.
for missing in ["before", "after"] {
try expectThrows("visual compare should require \(missing)") {
var parameters: [String: JSONValue] = [
"before": .string("one.png"), "after": .string("two.png"),
]
parameters.removeValue(forKey: missing)
try CommandRequest(
id: "visual-compare-missing-\(missing)", command: .visualCompare,
parameters: parameters
).validate()
}
}
try expect(visual.request?.parameters["before"] == .string("before.png"), "visual input should remain an artifact name")
let flow = try CLIParser().parse(["flow", "run", "happy-path.json"])
try expect(flow.request?.command == .flowRun, "flow run should parse")
Expand Down
8 changes: 6 additions & 2 deletions apps/headless/main.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1172,8 +1172,12 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
case .animationList:
result = try controller.agentAnimations()
case .visualCompare:
let before = request.parameters["before"]!.stringValue!
let after = request.parameters["after"]!.stringValue!
guard let before = request.parameters["before"]?.stringValue else {
return failure(request, code: "MISSING_PARAMETER", message: "Before artifact name is required.")
}
guard let after = request.parameters["after"]?.stringValue else {
return failure(request, code: "MISSING_PARAMETER", message: "After artifact name is required.")
}
guard let artifacts else { throw ArtifactError.invalidRoot }
_ = try artifacts.read(name: before, expectedExtension: "png", maximumBytes: 100 * 1_024 * 1_024)
_ = try artifacts.read(name: after, expectedExtension: "png", maximumBytes: 100 * 1_024 * 1_024)
Expand Down
7 changes: 5 additions & 2 deletions docs/roadmap/improvements-backlog.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,11 @@ clean restart.
`request.parameters["before"]!.stringValue!` on both hosts
(`LinuxHost/main.swift:239-240`, `main.swift:1175-1176`). Safe only while
`validate()` runs first; any future path that skips validation crashes the
host and kills every session. Replace with guarded extraction returning
`MISSING_PARAMETER`.
host and kills every session. ~~Replace with guarded extraction returning
`MISSING_PARAMETER`.~~ **Done** on both hosts, plus the nil-check-then-force-
unwrap in `HP/Diagnostics.swift:155`. The validator makes these parameters
required, so the guards are defence in depth; `ProtocolTests` now asserts that
requirement so the guards can never become the only thing holding the path up.

**A3. Oversized responses break the 1 MiB frame.** ([#14](https://github.com/LockInTime/headless/issues/14)) `qa report` can hold 500
events × ~4 KiB ≈ 2 MB; `artifact.list` is unbounded. `encodeLine` throws
Expand Down
Loading