Skip to content

fix(renovate): handle conda pin prefix in regex manager #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Sep 3, 2026
+15 −5
Merged

fix(renovate): handle conda pin prefix in regex manager #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions renovate-config.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@
"matchStrings": [
"(?<indentation>[ \\t]*)-[ \\t]*(?<depName>[A-Za-z0-9_.-]+)[ \\t]*=[ \\t]*(?<currentValue>[^=\\s#][^\\s#]*)",
],
"currentValueTemplate": "=={{{currentValue}}}",
"datasourceTemplate": "conda",
"packageNameTemplate": "conda-forge/{{{depName}}}",
"versioningTemplate": "conda",
Expand Down
19 changes: 14 additions & 5 deletions tests/renovate-config.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import fs from 'node:fs';
import test from 'node:test';

import JSON5 from 'json5';
import {api as condaVersioning} from 'renovate/dist/modules/versioning/conda/index.js';
import {extractPackageFile as extractCdnUrlPackageFile} from 'renovate/dist/modules/manager/cdnurl/index.js';
import {extractPackageFile as extractRegexPackageFile} from 'renovate/dist/modules/manager/custom/regex/index.js';
import {compile} from 'renovate/dist/util/template/index.js';
Expand Down Expand Up @@ -132,14 +133,14 @@ dependencies:
})),
[
{
currentValue: '1.2.3',
currentValue: '==1.2.3',
datasource: 'conda',
depName: 'doxygen',
packageName: 'conda-forge/doxygen',
versioning: 'conda',
},
{
currentValue: '4.5.6',
currentValue: '==4.5.6',
datasource: 'conda',
depName: 'graphviz',
packageName: 'conda-forge/graphviz',
Expand All @@ -149,16 +150,24 @@ dependencies:
);

const dependency = dependencies[0];
const newVersion = nextTestVersion(dependency.currentValue);
const currentVersion = dependency.currentValue.replace(/^==/, '');
const newVersion = nextTestVersion(currentVersion);
const newValue = condaVersioning.getNewValue({
currentValue: dependency.currentValue,
currentVersion,
isReplacement: false,
newVersion,
rangeStrategy: 'replace',
});
const updatedReplaceString = compile(
condaEnvironmentManager.autoReplaceStringTemplate,
{...dependency, newVersion},
{...dependency, newValue, newVersion},
false,
);
const updatedContent = content.replace(dependency.replaceString, updatedReplaceString);
const updatedDependencies = extractCondaDependencies(fileName, updatedContent);

assert.equal(updatedDependencies[0].currentValue, newVersion);
assert.equal(updatedDependencies[0].currentValue, newValue);
assert.match(updatedContent, new RegExp(` - doxygen=${newVersion.replaceAll('.', '\\.')}`));
assert.match(updatedContent, / - graphviz = 4\.5\.6 # Keep an inline comment\./);
});
Expand Down