Detailed Timer timing method override fix to apply to segment timer - #952
Merged
Conversation
CryZe
added
bug
CryZe
force-pushed
the
detailedTimerFix
branch
from
August 23, 2026 10:12
f60bc1f to
f1b28da
Compare
Collaborator
|
Oh wow good find. Thank you for fixing this. |
CryZe
enabled auto-merge (squash)
August 23, 2026 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I override my timing method to always be Game Time but found that the override was not being applied to the segment timer but it was being applied to the main timer.
Fix just has the override apply to the segment timer as well.
Included a test if you're into that.