WIP: Start on LiveSplit Server Protocol - #902
Conversation
5faad59 to
df19bc6
Compare
df19bc6 to
e6ca7a7
Compare
|
See also #955 |
|
I think the condition the |
|
Okay, I've incorporated that as In the time between when I first translated this and now, LiveSplit has added several new commands. I should translate those as well before I think of marking this as ready for review. The other main thing is testing. As far as I know, there are no integration tests for LiveSplit's server protocol. If there were, and if those integration tests also passed for this PR on a version of LiveSplit One that incorporates it such as LiveSplit One Druid, I would feel more confident in the readiness of this PR. |
|
Following commands are working for me: (using a livesplit-one-druid build as a LiveSplit server, and a Node.js net.Socket in an RPG Maker MV game as the client) however, I've noticed that |
|
I've just added a bunch more commands, including |
A WIP incomplete translation from
LiveSplit/src/LiveSplit.Core/Server/CommandServer.cs.I have only tested the
getsplitindexcommand so far, the rest of the commands are currently untested.Missing these commands entirely:
addloadingtimesalwayspausegametimesetsplitname/setcurrentsplitname