feat: local dev environment deploy config for VSCode#7798
feat: local dev environment deploy config for VSCode#7798ElectricalBoy wants to merge 11 commits into
Conversation
mbergen
left a comment
mbergen
left a comment
There was a problem hiding this comment.
Would probably make sense to also add a .env.example file so it's easier to setup the correct variables?
| os.getenv("LUA_DEV_ENV_NAME") is None | ||
| or os.getenv("LUA_DEV_ENV_NAME") != "/dev/" | ||
| ), f"Invalid dev environment: {os.getenv('LUA_DEV_ENV_NAME')}" | ||
| if len(sys.argv[1:]) == 0 and os.getenv("LUA_DEV_ENV_NAME") is None: |
There was a problem hiding this comment.
Do we need to further guard this path?
The modules should be protected, but there isn't really a reason why anyone would need this except for the scheduled deploy action.
There was a problem hiding this comment.
maybe having a prefix check won't hurt much now that I think about it...
There was a problem hiding this comment.
I was rather thinking about someone forgetting to set the environment variable.
So the suggestion would probably be to add a dedicated flag for the deploy-all instead
There was a problem hiding this comment.
I was rather thinking about someone forgetting to set the environment variable.
vscode will always prompt for a dev env name so I don't think extra check is needed and anyone using non-admin bot will face MW yelling anyway
that only leaves admin bots and I generally think that admins are careful enough not to screw live modules up
3 participants
Summary
This PR adds dev environment deploy tasks for VSCode.
Config assumes use of
venv.How did you test this change?
local dry runs