Skip to content

feat(Infobox): Add Character for Delta Force#7790

Open
Hesketh2 wants to merge 5 commits into
mainfrom
H2-DF-Character
Open

feat(Infobox): Add Character for Delta Force#7790
Hesketh2 wants to merge 5 commits into
mainfrom
H2-DF-Character

Conversation

@Hesketh2

@Hesketh2 Hesketh2 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Mostly just straight copy paste from VALORANT with some param chagnes

How did you test this change?

https://liquipedia.net/deltaforce/D-Wolf

@Hesketh2 Hesketh2 self-assigned this Jul 8, 2026
@Hesketh2 Hesketh2 requested review from a team as code owners July 8, 2026 11:04
Hesketh2 added 2 commits July 8, 2026 18:32
We need a way to for character portal to filter displays by class, so i'm going to make |class= able to store LPDB Data, unless there are more recommended way, please let me know
Comment on lines +44 to +57
Title{children = 'Abilities'},
Builder{
builder = function()
local gadgets = self.caller:getAllArgsForBase(args, 'gadget')
return {
Cell{
name = 'Gadgets',
children = gadgets,
}
}
end
},
Cell{name = 'Tactical Gear', children = {args.tacticalgear}},
Cell{name = 'Trait', children = {args.trait}}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem unneccessary to have in the infobox, as they are already present as their own this on the page

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valorant characters refference, they have it too on infobox and page

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems unnecessary too?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Delta Force–specific Module:Infobox/Character/Custom implementation to extend the shared Module:Infobox/Character with wiki-specific fields/widgets.

Changes:

  • Introduces a Delta Force CustomCharacter infobox module extending the common Character infobox.
  • Adds an “Abilities” section populated from gadget* args plus tacticalgear and trait.
  • Extends LPDB storage by adding extradata.class from class argument.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Hesketh2 added 2 commits July 8, 2026 19:24
push it to page content instead
@ElectricalBoy ElectricalBoy added the g: deltaforce Delta Force label Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants