perf: Memoize TeamTemplate.getRawOrNil#7777
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
hjpalpha
approved these changes
Jul 6, 2026
hjpalpha
left a comment
hjpalpha
left a comment
Collaborator
There was a problem hiding this comment.
lgtm assuming latest version is tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#6624 swapped all direct extension calls to use TT.getRawOrNil. This means lots of additional processing, as redirects are resolved, strings are gsub'd, and when the first call fails there's even a second extension call, leading to bad runtime.
This memoizes the function twice using the proposed memoize2 functionality
How did you test this change?
dev/ttmemo on https://liquipedia.net/valorant/VCL/2026/EMEA/Last_Chance_Qualifier/Play-In
After:
Before:
