Skip to content

feat: explicitly throw if TeamTemplate.getRawOrNil gets nil input #7705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElectricalBoy wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −3
Open

feat: explicitly throw if TeamTemplate.getRawOrNil gets nil input #7705

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac8dd13
better nil handling
ElectricalBoy Jun 30, 2026
2d0ee4f
just throw instead
ElectricalBoy Jun 30, 2026
673668f
markdown in docs
ElectricalBoy Jun 30, 2026
ce29ca9
adjust type annotation
ElectricalBoy Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lua/wikis/commons/TeamTemplate.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,14 @@ end
--[[
Same as TeamTemplate.getRaw, except that it returns nil if the team template
does not exist.

Throws if `team` is `nil`.
]]
---@param team string
---@param date string|number?
---@return teamTemplateData?
function TeamTemplate.getRawOrNil(team, date)
if Logic.isEmpty(team) then
return
end
assert(team ~= nil, 'TeamTemplate.getRawOrNil: \'team\' must not be nil')
team = team:gsub('_', ' '):lower()
Comment on lines -91 to 94

@Rathoz Rathoz Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

team:gsub throws if team is nil in the current implementation anyway

But that's not fully true? Since there's an early return if it's nil through the Logic Check?

@ElectricalBoy ElectricalBoy Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's adjusted behavior from #6624
pr description was true until #6624 was merged

@Rathoz Rathoz Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still work doing then?


-- return mw.ext.TeamTemplate.raw(team, date)
Expand Down
Loading