Skip to content

feat(match2): Disable collapsible for match information in ffa match summary#7661

Open
thangcoi02 wants to merge 1 commit into
mainfrom
thangcoi02-patch-1
Open

feat(match2): Disable collapsible for match information in ffa match summary#7661
thangcoi02 wants to merge 1 commit into
mainfrom
thangcoi02-patch-1

Conversation

@thangcoi02

@thangcoi02 thangcoi02 commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

PUBGM editors always hated how using both |mvp= and |comment= at the same time would hide those important info under a collapsible by default. I share the same view and personally think removing that collapsible would benefit all other wikis using ffa brackets.

How did you test this change?

|dev=tcoi at https://liquipedia.net/pubgmobile/PUBG_Mobile_World_Cup/2025#Grand_Finals

Before:
image
After:
image

…summary

PUBGM editors always hated how using both `|mvp=` and `|comment=` at the same time would hide those important info under a collapsible by default. I share the same view and personally think removing that collapsible would benefit all other wikis using ffa brackets.
@thangcoi02 thangcoi02 requested review from a team as code owners June 15, 2026 10:07

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opposed
this affects all wikis!

@thangcoi02

Copy link
Copy Markdown
Collaborator Author

It shouldn't affect anything other than brackets using ffa, no?

@mbergen

mbergen commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

It shouldn't affect anything other than brackets using ffa, no?

Yes, but on all wikis using FFA, not only on PUBG.
@PiddyNydra do you have an opinion on this?

@PiddyNydra

Copy link
Copy Markdown

Given we just rolled out a change on another module that collapses notes because they are being overloaded with info, I'm also not in favor, unless we get some major feedback from regular users.

Also, footnotes are by definition not important, they are tertiary information. I'd say keep them collapsed for now, if BR users strongly request having them uncollapsed we can revisit this.

@thangcoi02

Copy link
Copy Markdown
Collaborator Author

I didn't make this PR out of nowhere, PUBGM editors really hated how using just |mvp= or |comment= wouldn't create any kind of collapsible tab, but when using both of them together, all of a sudden infos are hidden behind a toggle. If normal match summary doesn't hide them under a collapsible, why does ffa do?

If adjusting this behavior for all wikis are too much, then i'll adjust this PR to only change this behavior for PUBGM since this is what they requested.

@ElectricalBoy

ElectricalBoy commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

tbf mvp/caster/comment stuff are not collapsed in non-ffa setup; in fact I don't recall why I made it collapsible in #5793 😛
but at the same time, I don't see a good reason to make them uncollapsed either as they are "less important" information compared to the actual match results

@PiddyNydra

Copy link
Copy Markdown

I can get behind showing the MVP outside the collapsable, to match the storytelling of other match popups

but i think any other notes (yes, including casters) should stay behind a collapsable as much less important information to regular users

@mbergen

mbergen commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

tbf mvp/caster/comment stuff are not collapsed in non-ffa setup; in fact I don't recall why I made it collapsible in #5793

It was a suggestion by Rath: #5793 (comment)

@PiddyNydra

Copy link
Copy Markdown

The way I see it is:

  • Notes and comments should always be collapsable. I don't trust editors across all FFA wikis to keep them small (in size and quantity) to warrant putting them out of collapsables
  • I can get behind putting the MVP out of the collapsable, as it's going to be just 1 more extra line. If other FFA wikis support this (so pinging @Kanopedia here for APEX, for example), let's makes the MVP more visible. But notes should 100% at all times be hidden for the regular user -- they are extremely granular, niche information that doesnt need to be visible at all times

@Kanopedia

Copy link
Copy Markdown
Collaborator

Seems somewhat fine to me; just a couple questions:

  • What if MVP's are set per game. Do they currently display on a game level?
  • Notes behind a collapsible seem fine to me; however; are we fine design wise having 3 collapsibles stacked upon each other? (Might also just be a different can of worms though)

@ElectricalBoy

Copy link
Copy Markdown
Collaborator

What if MVP's are set per game. Do they currently display on a game level?

iirc yes

@Rathoz

Rathoz commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

@thangcoi02 can you change teh logic to waht @PiddyNydra requested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants