chore: Reduce amount of live stylesheets loaded in tests#7656
Conversation
|
Topics for discussion/review:
|
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
would it make sense to properly integrate those styles into the existing style sheets?
(possibly oos)
apart from that question: lgtm on phone
Yes, but that is way easier for an employee with access to the current style sources instead of me trying to extract what i assume are the relevant parts from the large processed stylesheet that's currently loaded |
|
Buttons are being tweaked atm, so just awaiting that |
|
button styling has been updated |
# Conflicts: # lua/spec/snapshots/prize_pool.png # lua/spec/snapshots/tabs_dynamic_variants.png # lua/spec/snapshots/team_participant.png # lua/spec/snapshots/teamcard_legacy.png # lua/spec/tabs_snapshot_spec.lua
This reverts commit 254e67c. # Conflicts: # stylesheets/Main.scss
| /* Styles that are not yet part of this repository, but used in snapshot tests */ | ||
| :root { | ||
| --clr-moon-40: #666666; | ||
|
|
||
| --clr-primary-44: #1f73c1; | ||
| --clr-primary-100: #ffffff; | ||
|
|
||
| --clr-secondary-25: #404040; | ||
| --clr-secondary-80: #b3b3b3; | ||
| --clr-secondary-100: #ffffff; | ||
|
|
||
| --clr-semantic-gold-20: #665400; | ||
| --clr-semantic-gold-40: #ccab00; | ||
| --clr-semantic-gold-90: #fff5cc; | ||
|
|
||
| --clr-semantic-silver-40: #557177; | ||
|
|
||
| --clr-semantic-positive-30: #1d7c1d; | ||
| --clr-semantic-negative-40: #b81414; | ||
|
|
||
| --clr-on-surface-light-primary-4: rgba( 0, 0, 0, 0.04 ); | ||
| --clr-on-surface-light-primary-8: rgba( 0, 0, 0, 0.08 ); | ||
| --clr-on-surface-light-primary-12: rgba( 0, 0, 0, 0.12 ); | ||
|
|
||
| --clr-wiki-primary-container: #e2e2e6; | ||
| --clr-wiki-theme-primary: var( --clr-moon-40 ); | ||
| } |
There was a problem hiding this comment.
I've tried it without these, and infobox colors were off compared to current main
There was a problem hiding this comment.
There was a problem hiding this comment.
I can remove these changes and we can use this PR for testing, would that make sense?
# Conflicts: # lua/spec/snapshots/LeagueIcon.generate_copy_paste_gen.png # lua/spec/teamcard_legacy_spec.lua
4 participants
Summary
Sometimes, loading stylesheets seems to (partially) fail in CI.
This removes loading of skin-specific styles from the live server, loading only fontawesome styles.
Styles used in snapshot tests are (roughly) added to Main.scss, which is only used in tests.
Further, this introduces the
#snapshottag to only execute snapshot tests when usingnpm run update-snapshots.How did you test this change?
N/A