perf: render standings directly from the model on the producing page

[Rathoz]

Summary

• StandingsStorage.run now returns {record, entries} where record is a model-ready shallow copy of the storage record with matches restored as a Lua table (not a JSON string), and pagename set to the current page title
• StandingsTable.fromTemplate captures the return value and calls Standings.standingsFromRecord(stored.record, stored.entries) to build the model directly, then renders StandingsDisplay{standings = model} — eliminating the full stringify+parse round-trip through the wiki variable on the producing page
• Widget/Standings accepts an alternative standings prop (a prebuilt StandingsModel); when present it skips Standings.getStandingsTable entirely; the existing pageName/standingsIndex path is untouched
• The wiki-variable write (saveVars) is unchanged, so cross-template consumers (and later {{Standings}} transclusions on the same page) continue to work via the var path
• A new spec case 'direct-path render matches var-path render' builds a standings table, renders it both via the returned model and via the page-variable read, and asserts the two HTML strings are identical

How did you test this change?

• busted --run=ci: 606 successes / 0 failures / 0 errors (605 pre-existing + 1 new equality spec)
• luacheck on all modified files: 0 warnings / 0 errors

🤖 Generated with Claude Code

[hjpalpha]

seems reasonable on phone

[mbergen]

🤖 Generated with Claude Code

Does this only apply to the PR description or also the code itself?

[Rathoz]

Both, used it as a test scenario

[Copilot]

Pull request overview

This PR optimizes standings rendering on the producing page by building and rendering the StandingsModel directly from StandingsStorage.run() output, avoiding the stringify/parse round-trip through page variables while keeping the wiki-variable write path intact for cross-template consumers.

Changes:

• StandingsStorage.run now returns { record, entries }, where record is tailored for direct model construction (notably matches as a Lua table and pagename populated).
• StandingsTable.fromTemplate consumes that return value to build a model via Standings.standingsFromRecord(...) and renders via StandingsDisplay{standings = model}.
• Widget/Standings accepts an optional prebuilt standings prop and skips Standings.getStandingsTable when provided; adds a spec asserting direct-path render equals var-path render.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
lua/wikis/commons/Widget/Standings.lua	Adds support for rendering from a prebuilt StandingsModel instead of loading via page vars/LPDB.
lua/wikis/commons/Standings/Table.lua	Producing-page render now uses the model returned by storage instead of re-reading via vars.
lua/wikis/commons/Standings/Storage.lua	Reuses a single storage record for saves and returns a model-ready record + entries.
lua/spec/standings_model_spec.lua	Adds an equality test ensuring direct-path rendering matches the existing var-path output.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.