perf: use lookup maps instead of linear opponent scans in standings widgets

[Rathoz]

Summary

• The FFA widget previously used Opponent.same inside a per-cell nested loop to find an opponent's entry in each column round, producing O(R²·N²) Opponent.same calls per render. The Swiss widget had the same pattern at O(R·N²). Opponent.same is expensive: it can invoke uncached mw.ext.TeamTemplate.raw PHP callbacks for team opponents, or allocate and sort arrays for party opponents.
• Both widgets now build a entryByRound table once per standings render: an array (one entry per round) of { [Opponent.toName(entry.opponent)] = entry } maps. Opponent.toName returns a stable identity string (no PHP calls, no allocation). The per-cell lookup becomes a plain O(1) table access, and Opponent.toName(slot.opponent) is hoisted out of each row's per-column closure so it is computed once per row rather than once per column.
• All rounds of one standings table share the same stored opponent records, so toName keys are consistent across rounds — no fallback needed for entry lookups.
• The Array.indexOf(match.opponents, …) call inside the Swiss per-cell body (which identifies the opposing player in a 2-opponent match) is deliberately left on Opponent.same: those opponents come from match2 records where renamed-team handling in Opponent.same matters, and it is only ever called on 2 opponents per match, so it is not a performance concern.
• Rendered output is byte-identical to the original; this is a pure performance change.

How did you test this change?

• busted --run=ci (full suite): 605 successes / 0 failures / 0 errors — including spec/standings_model_spec.lua, which renders both the FFA and Swiss widgets end-to-end and asserts row ordering and cell content.
• luacheck on both modified files: 0 warnings / 0 errors.
• This branch is based on standings-tests-ai (PR test: add integration tests for standings #7647), which adds the widget render tests that lock the behavior being preserved here.

🤖 Generated with Claude Code

[hjpalpha]

lgtm on phone

fwiw it will make salts goal to allow A/B teams stuff harder

[mbergen]

fwiw it will make salts goal to allow A/B teams stuff harder

I'm currently convinced we'd need to support them inside Opponent.toName anyways (as other components, i.e. TeamParticipants use that), so the effect of this is probably not that bad.

[Copilot]

Pull request overview

Performance-focused refactor of the Swiss and FFA standings widgets to avoid repeated linear scans over round.opponents during rendering by precomputing per-round lookup maps keyed by opponent identity.

Changes:

• Build entryByRound once per render: an array of { [OpponentKey] = entry } maps per round.
• Replace Array.find(... Opponent.same ...) per-cell scans with O(1) entryByRound[columnIndex][slotKey] lookups.
• Hoist opponent key computation out of per-column closures (compute once per row).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
lua/wikis/commons/Widget/Standings/Swiss.lua	Precomputes per-round opponent→entry maps and uses them for per-cell match lookup in Swiss standings rows.
lua/wikis/commons/Widget/Standings/Ffa.lua	Precomputes per-round opponent→entry maps and uses them for per-cell point/status lookup in FFA standings rows.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.