chore: set publish = false (Closes #38) - #46
Conversation
Closes #38. The crate installs from git and has not been vetted for crates.io; crates.io is append-only so an accidental publish can't be undone. Add publish = false so cargo publish refuses until a deliberate release decision. https://claude.ai/code/session_01TPpTHPokxsZ3dQpRzg4NkD
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesPublish guard
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Overview
Closes #38 (High — release safety).
Cargo.tomlhad nopublishfield, so a straycargo publish(by a contributor following standard Rust practice, or a CI step) would push an unvetted crate to crates.io — which is append-only and can't be undone, only yanked.Adds
publish = falsewith a comment explaining when to remove it.Verification
cargo build— greencargo publish --dry-runnow refuses: "package.publishmust be set totrueor a non-empty list in Cargo.toml to publish."Closes #38
https://claude.ai/code/session_01TPpTHPokxsZ3dQpRzg4NkD
Generated by Claude Code
Summary by CodeRabbit