Skip to content

chore: set publish = false (Closes #38) - #46

Merged
Liohtml merged 1 commit into
mainfrom
claude/issue-38-publish-false
Jun 24, 2026
Merged

chore: set publish = false (Closes #38)#46
Liohtml merged 1 commit into
mainfrom
claude/issue-38-publish-false

Conversation

@Liohtml

@Liohtml Liohtml commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Overview

Closes #38 (High — release safety).

Cargo.toml had no publish field, so a stray cargo publish (by a contributor following standard Rust practice, or a CI step) would push an unvetted crate to crates.io — which is append-only and can't be undone, only yanked.

Adds publish = false with a comment explaining when to remove it.

Verification

  • cargo build — green
  • cargo publish --dry-run now refuses: "package.publish must be set to true or a non-empty list in Cargo.toml to publish."

Closes #38

https://claude.ai/code/session_01TPpTHPokxsZ3dQpRzg4NkD


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Added a safeguard to prevent accidental publishing of the package before the intended release.
    • Updated the changelog to reflect this release-related change.

Closes #38. The crate installs from git and has not been vetted for crates.io;
crates.io is append-only so an accidental publish can't be undone. Add
publish = false so cargo publish refuses until a deliberate release decision.

https://claude.ai/code/session_01TPpTHPokxsZ3dQpRzg4NkD
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b581074e-e490-4537-ae57-d2638434191c

📥 Commits

Reviewing files that changed from the base of the PR and between f19897d and b4f3fdc.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • Cargo.toml

📝 Walkthrough

Walkthrough

Cargo.toml gains publish = false in the [package] section, with inline comments explaining the guard and when to remove it. CHANGELOG.md records this under [Unreleased] → Changed.

Changes

Publish guard

Layer / File(s) Summary
publish = false guard and changelog entry
Cargo.toml, CHANGELOG.md
publish = false is added to the [package] section with comments warning against accidental crates.io publishing; the corresponding CHANGELOG.md entry is added under [Unreleased] → Changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

  • #38: Missing publish = false guard — This PR directly implements the remediation described in the issue by adding publish = false to Cargo.toml.

Poem

🐇 A tiny guard, a line of TOML,
No cargo slips out to the world unbidden!
publish = false — my paw stamps the seal,
Until we're ready, the crate stays hidden.
Hop hop, safe release, that's the deal! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding publish=false to Cargo.toml to block accidental publishing.
Linked Issues check ✅ Passed The PR adds publish=false under [package] and explains when to remove it, matching issue #38's release-safety requirement.
Out of Scope Changes check ✅ Passed The changelog note is directly tied to the publish guard, and no unrelated changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-38-publish-false

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Liohtml
Liohtml merged commit ef26900 into main Jun 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[repo-health] High: Missing publish = false guard — cargo publish would push an unprepared crate to crates.io

2 participants