[codex] Remove nonexistent PTO scale-address hardware entry - #65
Merged
Conversation
The outerCube design note no longer lists TGET_SCALE_ADDR as a PTO instruction candidate because v0.57 treats it as an IR/view helper with no hardware encoding. Constraint: PTO v0.57 only encodes concrete hardware-visible instructions Rejected: Keep TGET_SCALE_ADDR as a software-address row | the current PTO instruction set has no such instruction Confidence: high Scope-risk: narrow Tested: python3 tools/isa/check_pto_v057_encoding.py --spec isa/v0.57/state/pto_encoding.json
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Davinci_supersclar.md design document by removing the TGET_SCALE_ADDR instruction from the PTO ISA instruction mapping table. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The v0.57 documentation pass treats the Linx block as current architecture rather than inherited terminology. This removes stale Davinci and legacy wording from the pyCircuit design note without changing behavior. Constraint: v0.57 is the latest Linx block definition. Confidence: high Scope-risk: narrow Tested: rg -n "Davinci|DavinciOO|legacy|TGET_SCALE_ADDR|GET_VAL|SET_VAL" designs/outerCube/Davinci_supersclar.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the nonexistent
TGET_SCALE_ADDRhardware-entry row from the outerCube design note so the document matches the PTO v0.57 instruction boundary.Validation
python3 tools/isa/check_pto_v057_encoding.py --spec isa/v0.57/state/pto_encoding.jsonfrom the superprojectNotes
TGET_SCALE_ADDRremains an IR/view helper concept only; it is not encoded as a PTO hardware instruction.