avs: validate PTO ISA v0.2 QEMU Tile profiles - #159
Conversation
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
Signed-off-by: jialewang-316server <jialewangxox@gmail.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
zhoubot
left a comment
There was a problem hiding this comment.
This should remain draft and unmerged until LinxISA/qemu#39 is corrected and merged, then the gitlink is advanced to its upstream merge commit as the PR body requires. Also, the focused Tile gate skips the TMA descriptor/layout/padding tests: avs/qemu/tests/10_tile_tma.cpp:9-10 defaults LINX_TEST_ENABLE_TMA_DESC to 0, while run_tests.py:1281-1287 only emits macros registered in SUITES and never enables this one. Please enable it for --suite tile or narrow the L3 claims. The machine-readable coverage report still marks L2/L3 unavailable for this QEMU head, no CI checks are reported, and docs/bringup/qemu_pto_tile_support.md:167 says 18 fail-closed operations while the same page reports 14.
|
Review fixes are pushed in commit Changes:
Local gates:
Per the review requirement, the gitlink will only be advanced after LinxISA/qemu#39 is merged, using its upstream merge commit. |
Pin the superproject to the merged QEMU Tile implementation and add exact FP32/FP16/BF16 TCVT checks alongside padding probes that exercise both row and column padding. This keeps the positive conversion evidence paired with the author's fail-closed negative cases. Constraint: The superproject must reference the landed QEMU commit, not a pull-request head Rejected: Retain the pre-merge QEMU gitlink | it would make AVS evidence non-reproducible after squash merge Confidence: high Scope-risk: narrow Directive: Update the QEMU gitlink and focused Tile evidence together whenever supported dtype tuples change Tested: exact merged QEMU 50e3e9a build; focused Tile AVS including 0xA000E-0xA0011, 0xA0016, 0xA0029, 0xA002A; manifest; opcode/meta sync; layout; call/ret audit Not-tested: full AVS beyond the known DeepSeek 0x1702 liveness blocker; strict L1 coverage remains an unchanged baseline gap Signed-off-by: LinxISA Automation <linxisa-automation@users.noreply.github.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
zhoubot
left a comment
There was a problem hiding this comment.
Validated against merged QEMU commit 50e3e9a74a3e8d315b87944d21858392a0dcfb72. The Tile suite enables the descriptor lane, verifies corrected ND/NZ padding indexing, exercises exact FP32/FP16/BF16 TCVT encodings, and retains same-ACR negative rejection checks 0xA0029/0xA002A. Required descriptor IDs 0xA000E-0xA0011, manifest, opcode/meta sync, repository layout, and call/ret audit pass. Full AVS still reaches the documented unrelated DeepSeek 0x1702 liveness blocker; strict L1 coverage remains an unchanged baseline gap.
Refresh the Chinese mirror manifest after the Tile bring-up and generated gate documentation changed, so the documentation integrity check records the current English source hashes. Constraint: Translation freshness metadata must change with its tracked English source pages Rejected: Bypass the projection check | stale source hashes would leave the mirror status ambiguous Confidence: high Scope-risk: narrow Directive: Run docs/check_documentation.py after changing tracked English documentation Tested: python3 docs/check_documentation.py --root . Signed-off-by: LinxISA Automation <linxisa-automation@users.noreply.github.com>
zhoubot
left a comment
There was a problem hiding this comment.
Final re-review after refreshing translation-manifest hashes. All protected CI jobs now pass (guards, docs, lint, model, avs-contract). The exact merged-QEMU Tile AVS and local cross-stack gates remain green.
Summary
TMATMUL_BIAS, interleave/de-interleave, and partial arg selectionDepends on LinxISA/qemu#39. This PR should remain draft until that QEMU PR merges; after merge, the submodule gitlink must be advanced to the upstream QEMU merge commit before this PR is marked ready.
Version scope
The 111-operation count is the complete v0.2 target set, not the number of operations newly introduced in v0.2. Earlier commit subjects that mention v0.57 refer to the LinxISA encoding profile; history is preserved to avoid force-pushing an open PR.
Current support evidence
An execution path means at least one defined profile changes Tile, ACC, or memory state. It does not imply complete dtype, layout, shape, rounding, exception, or target-profile coverage.
TQUANT, MX profiles, unresolved implicit-destination or variable-operand forms, and Pipe/control operations remain fail-closed.Validation
QEMU=$PWD/emulator/qemu/build/qemu-system-linx64 LINX_VIRT_TEST_FINISHER=1 python3 avs/qemu/run_tests.py --suite tile --timeout 40ninja qemu-system-linx64git diff --checkin the superproject and QEMU submodulepython3 docs/check_documentation.py --root .The documentation gate passes generated SVG and instruction/group-page checks, but the repository baseline reports stale
docs/zh/translation-manifest.jsonsource/translation hashes. This PR does not rewrite unrelated translation freshness metadata.The full AVS
--allrun has an existing unrelated liveness blocker at DeepSeek test0x00001702; focused Tile PASS is not presented as a full-suite PASS.Submodules
.gitmodulesURLs are unchanged