Skip to content

Fix/web docker artifact cleanup - #51

Merged
LinMoQC merged 3 commits into
mainfrom
fix/web-docker-artifact-cleanup
Apr 25, 2026
Merged

Fix/web docker artifact cleanup#51
LinMoQC merged 3 commits into
mainfrom
fix/web-docker-artifact-cleanup

Conversation

@LinMoQC

@LinMoQC LinMoQC commented Apr 25, 2026

Copy link
Copy Markdown
Owner

Summary

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactor / code cleanup
  • CI / tooling

Related issue

Closes #

Changes

How to test

Screenshots (if applicable)

Checklist

  • My code follows the project's coding conventions
  • I have run ./lyra lint and there are no type errors
  • I have added/updated tests for the changed functionality
  • I have updated the documentation if behavior changed
  • The PR title follows Conventional Commits format (feat:, fix:, etc.)
  • I have read the CONTRIBUTING.md

@vercel

vercel Bot commented Apr 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lyra-note-web Ready Ready Preview, Comment Apr 25, 2026 6:39pm

@coderabbitai

coderabbitai Bot commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c4a31cd1-9efb-49e5-b3b6-665e662978e8

📥 Commits

Reviewing files that changed from the base of the PR and between 61867c2 and 0973ab4.

📒 Files selected for processing (5)
  • .github/workflows/build.yml
  • apps/api/app/services/source_service.py
  • apps/api/tests/unit/test_source_service_dispatch.py
  • packages/cli/src/commands/prod.js
  • packages/cli/src/commands/prod.test.js

📝 Walkthrough

Summary by CodeRabbit

发布说明

  • Chores

    • 更新CI/CD工作流以支持Monitoring镜像的构建和推送步骤
  • New Features

    • 生产更新前添加未提交改动检查,防止意外部署
    • 优化生产部署流程中的依赖镜像拉取机制
  • Tests

    • 为源数据服务添加了新的单元测试覆盖

概览

该变更为生产工作流添加 Monitoring 镜像构建步骤、在源数据摄入方法中集成可观测性追踪上下文、更新生产更新命令以验证 Git 工作区状态并动态配置服务拉取,并为相关功能添加对应的单元测试。

变更

变更组 / 文件 摘要
CI/CD 工作流
.github/workflows/build.yml
为 Monitoring 镜像构建添加新的工作流环节,包括元数据生成、镜像构建、推送及缓存管理,基础路径设置为 /ops
源数据服务可观测性
apps/api/app/services/source_service.py
rechunk_sourceupload_global_sourceimport_global_source_url 方法中集成 source_ingest 观测运行,记录上传阶段跨度,并将 trace_id/run_id 传播至入队的摄入任务。支持 .docx 文件类型识别。
源数据服务调度测试
apps/api/tests/unit/test_source_service_dispatch.py
新增单元测试验证全局摄入和重分块方法能正确注册 _after_commit_callbacks 回调,确保调度的 Celery 任务包含观测上下文和必需参数。
生产命令更新
packages/cli/src/commands/prod.js
添加 Git 工作区脏文件检查机制,当检测到未提交的本地变更时发出警告并提前退出;将 git pull 改为 --ff-only 模式;使用动态构建的 docker compose pull 命令替代硬编码的服务名列表,目标服务包括 apiwebmonitoring
生产命令测试
packages/cli/src/commands/prod.test.js
新增 Node 测试套件,验证 Git 状态解析、脏工作区指导信息生成及拉取命令构建的正确性。

代码审查工作量评估

🎯 3 (中等) | ⏱️ ~20 分钟

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/web-docker-artifact-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LinMoQC
LinMoQC merged commit ef4c208 into main Apr 25, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant