dev-yoyo

[Itz-Yoyo]

new JockeyRole
騎士職業 from dtc2
please check

[LilyKensa]

• Bad code style
• Wrong potion duration, it's measured in ticks
• Missing english translation for the role
• Inconsistent role description format

[Itz-Yoyo]

done

[Itz-Yoyo]

;-;

[Itz-Yoyo]

How JockeyRole work. for reviewing

[Itz-Yoyo]

4 new issues found by bensonshieh and ItzYoyo

• [Solved] horse inventory bug
• [Not Affect] getNearbyEntity queue randomly
• [Solved] horse access problem
• [Solved] being able to steal other player's horse inventory
• [Solved] horse death drop saddle and horse armor

[Itz-Yoyo]

5 new issues found by ItzYoyo and bensonhsieh

• [Unsolved] noble can't die (onPlayerDeath handling problem)
• [Unsolved] player death give noble 2 gold instead of 1 (first time death is working but not working after)
• [Unsolved] noble helmet is not cleaned after switching role -> setTrash()
• [Not Affect] switching role while on horse will evade detection, you can ride horse without being jockey
• [Unsolved] player is once noble cannot die (由儉入奢易 由奢入儉難)
  Imma go to [sleep]
  @LilyKensa pls explain how handlePlayerDeath work thx

[LilyKensa]

This branch is too unclear. I can help with the debugging IRL when you have free time.