Skip to content

💃 Adding Spanish Language to the game#12

Closed
Itz-Yoyo wants to merge 2 commits into
masterfrom
translating-fix
Closed

💃 Adding Spanish Language to the game#12
Itz-Yoyo wants to merge 2 commits into
masterfrom
translating-fix

Conversation

@Itz-Yoyo

Copy link
Copy Markdown
Collaborator

Yes

@Itz-Yoyo Itz-Yoyo requested a review from LilyKensa April 19, 2026 09:23
@Itz-Yoyo

Itz-Yoyo commented May 6, 2026

Copy link
Copy Markdown
Collaborator Author

@LilyKensa please review the branch. Thanks

public class TranslationsManager {

static public final Key key = Key.key("destroy-the-core:translations");
Locale spanish = new Locale("es");

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary

Locale.US,
Locale.TAIWAN
Locale.TAIWAN,
Locale.forLanguageTag("es-es")

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent

@@ -0,0 +1,1107 @@
general:
title: "<white>Asedio de Aniquilación III</white>"

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other languages ​​should align with the English name "Destroy The Core", the Chinese name is only kept for historical reasons

@LilyKensa LilyKensa left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if modifications are made, approval is not guaranteed

Adding other languages ​​is not recommended before a stable version of the plugin is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants