文章可讀性優化 + 遊戲化寫作 + 產出多國語系文章 + Generative Engine Optimization#202
Open
futianshen wants to merge 39 commits into
Open
文章可讀性優化 + 遊戲化寫作 + 產出多國語系文章 + Generative Engine Optimization#202futianshen wants to merge 39 commits into
futianshen wants to merge 39 commits into
Conversation
Raises post-page Lighthouse Accessibility 88→98 and SEO 92→100. - Dark inline/plain code colour #d65c5c (3.3:1) → #ffb0a3 (AA on the dark code surfaces) - Add alt="" to the about-the-author avatar (was missing the attribute) Remaining heading-order flag is post markdown starting at h3 (content, not template). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Generative-Engine-Optimization groundwork so LLM/AI crawlers can index the blog well. - /llms.txt: curated markdown index (site summary + all articles with absolute URLs + key pages/feeds), generated from collections.postsZhTW - robots.txt: explicit Allow for GPTBot, OAI-SearchBot, ChatGPT-User, ClaudeBot, Claude-Web, PerplexityBot, Google-Extended, Applebot-Extended; sitemap via metadata.url Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
futianshen
changed the title
Contributor
|
先說結論:整體架構很紮實(opt-in 機制、讀 git index 而非 working tree、sourceHash 驗證正確、build 與 10 個測試都會過),但這個 PR 把四個獨立功能綁在一起,有一些值得討論的地方。 亮點
建議討論1. PR 範圍過大 + 缺描述這個 PR 一次包了「文章可讀性(TOC)」「遊戲化寫作」「多國語系 i18n」「GEO(llms.txt / robots)」四件事,56 個檔案、+3077/-290,且 PR body 是空的。對 reviewer 負擔很大,也增加 revert 的顆粒度。建議至少補上 PR 描述說明動機與測試方式;若可能,拆成 2~3 個 PR 會更好 review。 2. 翻譯測試不在
|
- Exclude page-list.njk from output; clean _site before production builds so stale per-language pages can't linger (scripts/clean-output.js) - Languages with no published translations no longer emit home, About, author pages, or feeds (collections.siteLangsWithPublishedPosts) - Draft translations are kept out of sitemap, hreflang, feeds, and the language switcher - Sitemap now verifies every URL has real build output and rejects duplicates and malformed URLs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Pin Node 24 across .nvmrc, package.json engines, lockfile, Netlify - Add push/PR CI workflow: npm ci -> npm run build - Update actions to checkout@v6, setup-node@v6, codeql-action@v4 - Wire clean/test scripts into npm run build Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Replace skipped boilerplate tests with assertions against the real homepage and post output - Add coverage for sitemap, per-language pages, hreflang, internal docs exclusion, and the image pipeline - Missing, unreadable, or badly URL-encoded local images now fail the build instead of warning; data: URIs and remote images still skipped - Fix Sharp write race when multiple pages process the same image Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- sourceHash now covers title + body, so title changes mark translations stale; existing translations migrated to the new hash - Staged translation deletions are now reported as missing - Add --all mode so CI validates the whole checkout, not just staged files; pre-commit still reads the Git index precisely - Update AGENTS.md to document the new hash semantics Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Git hook runners (pre-commit/pre-push packages) export GIT_DIR and GIT_INDEX_FILE to child processes. The translation-guard integration tests inherited them, so every 'git add' inside their temporary repos rewrote the actual repository's index — staging the whole tree as deleted plus four posts/tester fixtures. Strip GIT_* from the environment of every git/guard subprocess so the temp repos stay hermetic. Verified by running the suite under a hostile GIT_INDEX_FILE. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Homepage cards linked /posts/<display name> (e.g. /posts/Benben) and five author keys (Xiang, Cian, Umer, Ruofan, Lavi) were capitalized while their page directories are lowercase, so those links 404 on the case-sensitive production host. Use the author key in home-postslist and normalize the five keys to match their directories across metadata.json, post frontmatter, and the author index pages. Display names are unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
netlify.toml force-redirects /archive/:page to /archive/, so any second pagination page would be unreachable. Raise the page size well above the post count and document the constraint next to the pagination block. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Extend the AI-crawler allowlist in robots.txt to the crawlers feeding Meta, Amazon, and Common Crawl (which most model training sets consume), matching the existing GEO policy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
/css/* assets are fingerprinted via addHash, so they can share the same immutable cache policy as /js/*. Archive rows render one avatar per post; mark them loading=lazy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The inline script that applies the colour theme before first paint was missing the csp-hash attribute, so re-enabling the site's CSP meta tag would block it and reintroduce the dark-mode flash. apply-csp.js only whitelists inline scripts carrying this attribute. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Force CI and Netlify to evaluate draft visibility as production, while keeping local serve behavior explicit. Remove the PurgeCSS v3 option that the pinned v2 release silently ignores.
Prefer original image files over passthrough copies that Eleventy may still be writing. Keep generated derivatives in _site and retain the existing fallback for generated-only assets.
Derive site and translation guards from langs.json, validate required locale strings, and preserve dotted source slugs. Add a non-redirecting preferred-language banner, localized RSS links and 404 guidance, while keeping the zh-TW tags index source-only.
Provide Tian's translated biographies and route homepage author links to localized author pages only when those pages actually exist.
added 13 commits
July 13, 2026 03:17
Escape the resolved title instead of only the fallback operand. Remove the stale site-wide 2020 date, prefer real page or Git modification timestamps, and omit lastmod when no trustworthy value exists.
Explain the langs.json single source of truth, per-post opt-in and review flow, and localized author biography fallback for new contributors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.