Add Celeste Any% + IL Autosplitters + Splits#25
Open
rellort1 wants to merge 4 commits into
Open
Conversation
Contributor
|
Chonky PR here, I see! Do you prefer waiting for 369 to be merged or do you prefer having things merged sooner and go back to edit stuff later? |
Author
|
I think its fine, theoretically you shouldnt need to do any of those things in the first place :p I guess it would be good to add it to the readme at least. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I havent tested every chapter in every split, but everything I tested was working.
The split logic will break if people skip/undo/manually split, requires LibreSplit/LibreSplit#369 to fix, but this felt like the best solution to handle all the edge cases and also allow for easily reusing on the other categories when I get around to that.