Open pending Contact Status read-only - #1537
Merged
Merged
Conversation
dnlbui
marked this pull request as ready for review
August 5, 2026 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR keeps Contact Status available for viewing while an
update_toll_requiredtransaction is pending.FriendModal.opennow activates the modal and displays the cached or optimistic selection before applying the pending guard.Fixed Flow
Why
The previous pending guard returned before the modal became active. That prevented conflicting submissions, but also hid the entire status interface and blocked offline, reaction, and video-call setup flows waiting for it to open. Moving the guard into the modal state preserves the original transaction protection while restoring read access.
Validation
node --check app.jsnode --test /tmp/contact-status-refresh.test.mjs(temporary focused harness covering pending open/toast, connectivity, settlement refresh, offline, failure, and timeout)git diff --check origin/main...HEADCloses #1536