Skip to content

Add EVM send confirmation and signing modal - #1532

Merged
osyed merged 1 commit into
mainfrom
agent/evm-send-signature-modal
Aug 4, 2026
Merged

Add EVM send confirmation and signing modal#1532
osyed merged 1 commit into
mainfrom
agent/evm-send-signature-modal

Conversation

@Texaglo

@Texaglo Texaglo commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Add an explicit confirmation modal before an EVM asset transfer is locally signed and broadcast. The flow reuses the established Liberdus send-confirmation UI while keeping EVM-specific details and event handling isolated in evm-assets.js.

Closes #1531

Changes

  • add a dedicated EvmSendConfirmationModal adapter
  • reuse the existing send-confirmation modal without changing the Liberdus wallet flow
  • display the EVM network and chain ID
  • display the asset, amount, estimated USD value, recipient, and maximum network fee
  • retain a Liberdus username in confirmation instead of exposing its internally resolved EVM address
  • explain that wallet signing happens locally and the private key does not leave the device
  • require explicit confirmation before signing or broadcasting
  • intercept Confirm, Cancel, Back, and browser-back actions only while an EVM confirmation is pending
  • safely re-enable the EVM send form after cancellation
  • reset any pending confirmation when EVM Assets state is reset
  • keep all implementation changes isolated to evm-assets.js

Validation

  • node --check evm-assets.js
  • node --check app.js
  • git diff --check origin/main...HEAD
  • confirmation cancellation smoke test verifies:
    • the username display label is retained
    • cancellation returns a cancelled status
    • no raw transaction is broadcast
  • local browser validation verifies:
    • the BNB send confirmation displays recipient, amount, USD estimate, network, fee, and local-signing notice
    • Cancel safely returns to the send form
    • Back safely returns to the send form
    • no transaction is broadcast during cancellation testing

Scope

No backend, HTML, CSS, or Liberdus wallet files are changed. No live transaction was broadcast during validation.

@Texaglo
Texaglo marked this pull request as ready for review August 4, 2026 22:54
@dnlbui
dnlbui force-pushed the agent/evm-send-signature-modal branch from 372a4c9 to 505f1ca Compare August 4, 2026 23:26
@osyed
osyed merged commit 02d62f3 into main Aug 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EVM Assets: add transaction confirmation and local-signing modal

2 participants