Consolidate modal naming and close APIs - #1528
Merged
Merged
Conversation
dnlbui
marked this pull request as ready for review
August 4, 2026 21:40
Contributor
Author
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
dnlbui
force-pushed
the
agent/align-modal-close-apis
branch
2 times, most recently
from
August 4, 2026 22:28
9210c2f to
cdf6283
Compare
dnlbui
force-pushed
the
agent/align-modal-close-apis
branch
from
August 4, 2026 22:50
cdf6283 to
9d55d71
Compare
dnlbui
force-pushed
the
agent/align-modal-close-apis
branch
from
August 4, 2026 23:03
9d55d71 to
4bc90f4
Compare
- Updated modal references throughout app.js to use standardized naming conventions, improving code readability and maintainability. - Renamed instances of myProfileModal, backupAccountModal, validatorStakingModal, scanQRModal, searchMessagesModal, and searchContactsModal to their new counterparts: accountModal, backupModal, validatorModal, qrScanModal, searchModal, and contactSearchModal respectively. - Adjusted event listeners and modal handling to reflect these changes, ensuring seamless functionality across the application.
osyed
force-pushed
the
agent/align-modal-close-apis
branch
from
August 4, 2026 23:03
4bc90f4 to
4859077
Compare
- Updated references in app.js and index.html to reflect the new naming convention for the message search modal. - Adjusted event listeners and modal handling to ensure seamless functionality with the updated modal name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR consolidates modal controller naming and dismissal conventions so conventional modals can use the shared handler helper directly.
chatSettingsModal,importContactsModal, andshareContactsModalexpose guarded user dismissal through.close()..forceClose()when they must bypass dismissal warnings.Consolidated Flow
.close()method..forceClose()to finish cleanup without triggering a dismissal warning.Why
This is a behavior-preserving consolidation after the shared browser-back registry. The registry still needed alias rows for mismatched controller names and special
handleClose()mappings for guarded modals.Aligning controller names with DOM IDs and making
.close()the consistent public dismissal API lets the shared helper cover those modals without changing user-facing behavior.Validation
node --check app.jsnode --test tests/modal-close-coverage.test.mjsgit diff --check agent/fix-modal-browser-back...HEADCloses #1527