Harden unstake pending settlement and staking UI refresh - #1469
Merged
Conversation
dnlbui
marked this pull request as draft
July 23, 2026 17:01
Contributor
Author
|
close for now. Can rebase and use this branch when we want to pick up the issue again. |
Keep unstake settlement independent of the staking modal, show pending confirmation instead of premature success, and treat receipt timeouts as unresolved rather than silent terminal outcomes. Co-authored-by: Cursor <cursoragent@cursor.com>
Eliminate the unstake.settlement.js file and its associated functions, streamlining the ValidatorStakingModal by directly handling pending transactions and UI updates. Adjusted the modal's state management to improve clarity and responsiveness during stake and unstake operations. This change enhances the user experience by simplifying the codebase and ensuring consistent handling of transaction states.
dnlbui
force-pushed
the
fix/1466-unstake-settlement
branch
from
August 6, 2026 17:49
3ef64be to
63e12bb
Compare
Simplify the display logic for pending transactions by consolidating the text assignment for stake and unstake operations. Update comments for clarity regarding the refresh of pending transactions. This change enhances code readability and maintains consistent user feedback during transaction processing.
Contributor
Author
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1184880a53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Reintroduce the logic to refresh pending transactions and update the UI after fetching validator details. This change ensures that the latest pending transactions are accurately reflected in the user interface, enhancing the responsiveness and clarity of the staking modal. The previous redundant code in the finally block has been removed for cleaner execution flow.
Contributor
Author
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
dnlbui
marked this pull request as ready for review
August 6, 2026 22:12
Update the ValidatorStakingModal to improve the display of pending transaction statuses. Change comments for clarity and modify the text content for stake and unstake confirmations. Introduce a new CSS class for pending status elements, ensuring a more user-friendly experience during transaction processing. This refactor streamlines the UI and enhances responsiveness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR makes
withdraw_stakesettlement reliable across modal navigation and every receipt outcome while clearly separating pending-operation status from confirmed staking data.ValidatorStakingModalderives pending UI and action state frommyData.pending, revalidates controls after the submission cooldown, and blocks duplicate stake or unstake actions while confirmation is pending.Fixed Flow
Why
Previously, accepted injection immediately closed and reopened the staking modal, which blurred submission versus confirmation and coupled settlement feedback to modal navigation. The pending indicator also lived inside Your Stake Info and could force the details container visible after a load error. Using global pending state as the source of truth and a separate top-level status banner keeps operation status, confirmed staking data, navigation, and error rendering independent.
Validation
node --check app.jsgit diff --checkCloses #1466