fix: drop importing LED settings from a theme - #39
Merged
Conversation
josegonzalez
force-pushed
the
drop-led-management
branch
from
September 11, 2025 23:50
5bbcb33 to
87ab5ab
Compare
LEDs are usually set manually by users and can even be done on a per-console or game basis, and thus do not really belong in themes. It is removed in this commit to avoid issues where users have to go back and reset their LED settings after adding a theme.
josegonzalez
force-pushed
the
drop-led-management
branch
from
September 12, 2025 00:19
87ab5ab to
6b57966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEDs are usually set manually by users and can even be done on a per-console or game basis, and thus do not really belong in themes. It is removed in this commit to avoid issues where users have to go back and reset their LED settings after adding a theme.