Include lib/actions/rename.cjs in published package (fixes #2)#4
Open
shackstack wants to merge 1 commit into
Open
Include lib/actions/rename.cjs in published package (fixes #2)#4shackstack wants to merge 1 commit into
shackstack wants to merge 1 commit into
Conversation
cc-switch.cjs requires ./lib/actions/rename.cjs at load time (the --rename / rename path), but rename.cjs was missing from the package.json "files" allow-list. As a result the published npm package omits it and every cc-switch invocation crashes with MODULE_NOT_FOUND, not just the rename subcommand. Add lib/actions/rename.cjs to "files" so it ships. Fixes Leuconoe#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cc-switch.cjsdoesrequire('./lib/actions/rename.cjs')at load time, so the file is needed for the CLI to start at all. Butpackage.json'sfilesallow-list omitslib/actions/rename.cjs(it listssync,usage,remove,list,switchbut notrename).The file exists in the repo, so it works from a git checkout — but the published npm package drops it, and every
cc-switchinvocation then crashes:This takes down the whole CLI, not just the
renamesubcommand.Fix
Add
lib/actions/rename.cjsto thefilesarray. Verified withnpm pack --dry-run:Fixes #2