feature/illumos-support#67
Merged
Merged
Conversation
LeoBorai
approved these changes
Dec 17, 2025
Owner
|
Hi @snltd, thanks for your PR! I think its okay to merge it given that it doesn't change any behavior in terms of logic. But I think it would also be great to have integrity checks on it, its there any recommended approach on testing in GH Actions? Perhaps we can add CI in a separate PR? |
Contributor
Author
|
I have some stuff buildig in OmniOS from GHA, but it's a little heavyweight. e.g. https://github.com/snltd/gurp/actions/workflows/release.yml. I'd be happy to put together a similar action if you wish. |
Owner
Hi @snltd, that would be great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the crate to build on illumos. It's just another Unix target, so I didn't need to make any changes to the code.
Tests pass. Checked with rust 1.92.0.