feat: interface can be filtered and flags by hanskorg · Pull Request #66 · LeoBorai/network-interface

hanskorg · 2025-12-02T03:19:12Z

unix like os uses interface ifa_flags to map interface types, on windows
It uses IfType
add filter fn

///  This helps people filter interfaces that look like`Ethernet` and are running
NetworkInterface::filter(NetworkInterface::show().unwarp(), IFF_ETH   | IFF_RUNNING)

Compared to the previous failed pull request, more testing was done on Windows systems. Several magic numbers were replaced with Windows API constants.

- unix like os use interface `ifa_flags` to map interface types, windows use `IfType` - add filter fn:wq

- windows not set flags - filter `netif.flags` empty remove

- format code by running `cargo fmt` - add some comments for constants

- windows interface verify - demo lint

Copilot

Pull request overview

This PR adds interface filtering functionality and platform-specific flag mapping to distinguish between different network interface types. It introduces a Status enum to represent interface operational status and adds a filter() method to allow users to filter network interfaces by flags (e.g., Ethernet, wireless, tunnel, loopback).

Adds Status enum with Unknown, Up, Down, and Unavailable states
Adds filter() method to NetworkInterfaceConfig trait for filtering interfaces by flags
Maps Unix ifa_flags and Windows IfType to custom flag constants for cross-platform filtering
Updates NetworkInterface struct to include status and flags fields

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 19 comments.

Show a summary per file

File	Description
src/lib.rs	Adds `filter()` method to `NetworkInterfaceConfig` trait with documentation
src/interface.rs	Defines `Status` enum, flag constants for both Unix and Windows, adds `status` and `flags` fields to `NetworkInterface`, adds `is_up()` helper method
src/target/windows.rs	Implements `filter()` method, adds `get_adapter_operstatus()` and `get_adapter_flags()` functions to map Windows adapter types to custom flags
src/target/unix/mod.rs	Implements `filter()` method, adds `netifa_status()` function to map Unix flags to `Status` enum, updates interface creation to include status and flags
src/target/linux.rs	Implements `filter()` method, adds `netifa_status()` function for Linux-specific status mapping, updates interface creation to include status and flags
examples/demo.rs	Updates example to demonstrate filtering by `IFF_ETH \| IFF_RUNNING` flags
Cargo.toml	Removes duplicate "network" keyword and adds explicit example configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-02T23:37:59Z

+    Unavailable,
+}
+
+/// Filter Running deivces, on Windows, it has no effect


Typo: "deivces" should be "devices".

Copilot · 2025-12-02T23:37:59Z

+/// Filter Running deivces, on Windows, it has no effect
+#[cfg(target_os = "windows")]
+pub const IFF_RUNNING: i32 = 0x40;
+/// Filter Ethernet interfaces, on *unix is can be `IFF_UP | IFF_BROADCAST | IFF_MULTICAST`, on windows adapter `ifType` is used


Typo: "is can be" should be "can be".

Copilot · 2025-12-02T23:37:59Z

+/// Filter Ethernet interfaces, on *unix is can be `IFF_UP | IFF_BROADCAST | IFF_MULTICAST`, on windows adapter `ifType` is used
+#[cfg(target_os = "windows")]
+pub const IFF_ETH: i32 = 0x1;
+/// Filter Wireless interfaces sometimes it sames as Eth, on windows adapter `ifType` is used.


Typo: "sames" should be "same".

Copilot · 2025-12-02T23:38:02Z

+pub const IFF_WIRELESS: i32 = 0x2;
+///Filter out TUN interfaces. Note! This is only a hypothesis. on windows adapter `ifType` is used.
+#[cfg(target_os = "windows")]
+pub const IFF_TUN: i32 = 0x1 | 0x4;


The IFF_TUN constant is defined as 0x1 | 0x4 which equals 0x5. However, looking at get_adapter_flags() in windows.rs (line 350), IF_TYPE_TUNNEL maps to IFF_TUN which should be 0x4, but the constant here is 0x5. This inconsistency means filtering by IFF_TUN won't correctly match tunnel interfaces because 0x4 & 0x5 != 0x5.

Suggested change

pub const IFF_TUN: i32 = 0x1 | 0x4;

pub const IFF_TUN: i32 = 0x4;

@hanskorg have you checked on this one? I'm not a Windows expert.

I would appreciate your input here.

Copilot · 2025-12-02T23:38:02Z

+/// Filter Wireless interfaces sometimes it sames as Eth, on windows adapter `ifType` is used.
+#[cfg(not(target_os = "windows"))]
+pub const IFF_WIRELESS: i32 = libc::IFF_UP | libc::IFF_BROADCAST | libc::IFF_MULTICAST;
+///Filter out TUN interfaces. Note! This is only a hypothesis. on windows adapter `ifType` is used.


Missing space after /// in the comment. Should be /// Filter out TUN interfaces... for consistency with other comments.

Copilot · 2025-12-02T23:38:02Z

+    Unknown,
+    /// device is up
+    Up,
+    /// deivce down, by default you can't get device markd `down`


Typo: "deivce" should be "device".

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

infra-bot and others added 17 commits November 27, 2025 15:37

features: status & type

03b7794

- unix like os use interface `ifa_flags` to map interface types, windows use `IfType` - add filter fn:wq

fixbugs

451d334

- windows not set flags - filter `netif.flags` empty remove

fixbug: a bad code

c766de5

fixbug: a bad code

9c6f8ad

del repeated keyword

8d38abf

approve the owner's and AI's review suguestions

288628a

fix: add flags to NetworkInterface struct initialization

a98f18f

typo & format

ca9b492

- format code by running `cargo fmt` - add some comments for constants

typo & format

40244ac

- format code by running `cargo fmt` - add some comments for constants

Merge branch 'main' of github.com:hanskorg/network-interface

947db36

Fix IFF_TUN to IFF_TEH in demo.rs

005c1b1

demo's typo error

a96c3ee

ship windows lint warn,fix doc test error

1e79cf1

fixbug

e370236

- windows interface verify - demo lint

Merge branch 'main' of https://github.com/hanskorg/network-interface

8c8c752

rm iff vpn verify

15c7c3a

improve doc

407aa07

LeoBorai requested a review from Copilot December 2, 2025 23:33

Copilot started reviewing on behalf of LeoBorai December 2, 2025 23:33 View session

Copilot finished reviewing on behalf of LeoBorai December 2, 2025 23:36

Copilot AI reviewed Dec 2, 2025

View reviewed changes

LeoBorai and others added 7 commits December 4, 2025 01:11

fix: rm duplicate serde derive

f4b0f0e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: typo

cc7ef46

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: typo

fe5d55c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: missing space

1cb2516

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: missing space

fa6c9ce

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: missing space

c544f41

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into main

219ad26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: interface can be filtered and flags #66

feat: interface can be filtered and flags #66
hanskorg wants to merge 24 commits into
LeoBorai:mainfrom
hanskorg:main

hanskorg commented Dec 2, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 2, 2025

Uh oh!

Copilot AI Dec 2, 2025

Uh oh!

Copilot AI Dec 2, 2025

Uh oh!

Copilot AI Dec 2, 2025

Uh oh!

LeoBorai Dec 4, 2025

Uh oh!

Copilot AI Dec 2, 2025

Uh oh!

Uh oh!

Copilot AI Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	pub const IFF_TUN: i32 = 0x1 \| 0x4;
	pub const IFF_TUN: i32 = 0x4;

Conversation

hanskorg commented Dec 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

LeoBorai Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants