Reuse a mutable position while scanning ship blocks#564
Open
frostdev-ops wants to merge 1 commit into
Open
Conversation
Skipped positions (air and left-behind blocks) are the majority of a ship's bounding box; scan them with a single MutableBlockPos. The position switches to an immutable copy before reaching getTileEntity or JumpBlock, covering the missing-tile-entity recreation path that would otherwise retain the mutable and corrupt the world.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #561 per review.
Uses a single MutableBlockPos for the skip path of the ship scan (air and left-behind blocks, which is most of the bounding box). The position switches to toImmutable() before it can reach getTileEntity or the JumpBlock constructor, covering the missing-tile-entity recreation path that would otherwise hold onto the mutable and corrupt the world. Left a comment in the code about that edge case so nobody re-trips it.