fix: preserve native MVCP position on item resize against a bottom inset#481
Draft
trcoffman wants to merge 2 commits into
Draft
fix: preserve native MVCP position on item resize against a bottom inset#481trcoffman wants to merge 2 commits into
trcoffman wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When a virtualized list uses maintainVisibleContentPosition with a bottom contentInset (e.g. KeyboardAwareLegendList's anchoredEndSpace blank), resizing an item above the viewport shifted the content on iOS and Android. Route item-resize MVCP through the native-clamp handoff whenever the viewport overlaps the inset zone, and: - apply the full compensation manually when native has room and would not clamp (partial-inset zone), - settle without a further spacer adjust once native has clamped to its true max, so a large shrink pins cleanly at the new end instead of overshooting. The data-change handoff is unchanged (scoped via isResize). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
trcoffman
force-pushed
the
fix/mvcp-resize
branch
from
c7c7260 to
325df8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #475
When a virtualized list uses maintainVisibleContentPosition with a bottom contentInset (e.g. KeyboardAwareLegendList's anchoredEndSpace blank), resizing an item above the viewport shifted the content on iOS and Android.
Route item-resize MVCP through the native-clamp handoff whenever the viewport overlaps the inset zone, and:
The data-change handoff is unchanged (scoped via isResize).
In these videos, the example has a timer that re-collapses the expanded messages after 5 seconds.
Before
Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-06-22.at.14.48.59.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-06-22.at.14.49.32.mov
After
Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-06-22.at.14.44.51.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-06-22.at.14.46.29.mov