feat: add account.getPublicKey Wallet API method#587
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 9bc0fa4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lysyi3m
force-pushed
the
feat/account-get-public-key
branch
from
9e80135 to
2a27717
Compare
lysyi3m
force-pushed
the
feat/account-get-public-key
branch
from
2a27717 to
9bc0fa4
Compare
Justkant
approved these changes
Jun 22, 2026
Comment on lines
+115
to
+117
| * @param accountId - id of the account | ||
| * @param derivationPath - optional derivation path (used by UTXO families) | ||
| * |
Collaborator
There was a problem hiding this comment.
That's fine for now, it's true that we could have more families use the derivation path but I'll let you decide if you want to update that or not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a generic
account.getPublicKeymethod to the Wallet API, letting a connected wallet return an account's public key over RPC. Modeled on the existingbitcoin.getPublicKey, but namespaced underaccountso any family can supply a resolver.core: newAccountGetPublicKeyspec (zod params/result + handler type), exported and added to theWalletHandlersmapserver: handler-map type plus an internal RPC handler that forwards to the wallet-side handler, rejecting withnotImplementedByWalletwhen none is registeredclient:account.getPublicKey(accountId, derivationPath?)returning the parsedpublicKeysimulator: capability entry, stub, and tests covering the success, missing-permission, and not-implemented pathsBehavior notes:
derivationPathis optional, matchingbitcoin.getPublicKey— families that derive keys at a path can use it; others ignore it.publicKeyis returned in the family's own encoding; the result schema isz.string().Backward-compatible — an additive method on the shared packages. Peers that don't implement it reject with the standard "not implemented" error rather than failing to parse.
Minor bump for
wallet-api-core,-client,-server, and-simulatorvia changeset.