Generic helpers#281
Merged
Merged
Conversation
cedelavergne-ledger
requested review from
fbeutin-ledger
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
+ Coverage 70.27% 75.64% +5.36%
==========================================
Files 39 46 +7
Lines 2493 3055 +562
==========================================
+ Hits 1752 2311 +559
- Misses 741 744 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cedelavergne-ledger
force-pushed
the
cev/generic_helpers
branch
3 times, most recently
from
e54f670 to
3393486
Compare
cedelavergne-ledger
force-pushed
the
cev/generic_helpers
branch
2 times, most recently
from
83b2730 to
5fcb185
Compare
cedelavergne-ledger
force-pushed
the
cev/generic_helpers
branch
from
5fcb185 to
65db1d1
Compare
cedelavergne-ledger
force-pushed
the
cev/generic_helpers
branch
from
65db1d1 to
a06df21
Compare
fbeutin-ledger
approved these changes
Jun 26, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add generic TLV helper module
Add generic AddressBook helper module
Add the corresponding Unit Tests
Bonus: Declare missing PubKeyUsage for PKI
This PR is validated against app-ethereum here: https://github.com/LedgerHQ/app-ethereum/tree/cev/new_ragger_helpers