Add --log_apdus option#279
Closed
fbeutin-ledger wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 75.88% 75.65% -0.23%
==========================================
Files 38 38
Lines 2289 2325 +36
==========================================
+ Hits 1737 1759 +22
- Misses 552 566 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| It can be useful to record all the APDU transmitted between the client and the | ||
| application during a test. the ``--log_apdu_file`` allows to specify a file | ||
| path in which every :term:`APDU` and :term:`RAPDU` will be recorded. | ||
| application during a test. |
Contributor
There was a problem hiding this comment.
I think the default --log_apdu_file alone should be sufficient. Please double check with the option itself, without giving a file name...
fbeutin-ledger
force-pushed
the
fbe/log_apdus
branch
from
9cd925c to
6277736
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.