Skip to content

fix(core): encode GitLab version-endpoint auth in dag-init probe #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeXwDeX merged 2 commits into from
Aug 17, 2026
+13 −6
Merged

fix(core): encode GitLab version-endpoint auth in dag-init probe #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b08f205
Merge pull request #310 from LeXwDeX/dev
LeXwDeX Aug 17, 2026
499f892
fix(core): encode GitLab version-endpoint auth requirement in dag-ini…
LeXwDeX Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions packages/core/src/plugin/command/dag-init.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,17 @@ Arguments (optional): $ARGUMENTS
- Not a git repo, or no `origin` → STOP: "`/dag-*` requires a git remote."
- Host is `github.com` → platform `github`, CLI `gh`.
- Host is `gitlab.com` → platform `gitlab`, CLI `glab`.
- Any other host → probe whether it is a self-hosted GitLab:
`curl -sSf https://<host>/api/v4/version` (or `glab api version` against
that host once authed). Responds as GitLab → platform `gitlab`
(self-hosted), CLI `glab` pinned to that host. Otherwise → STOP:
"unsupported platform: only GitHub and GitLab (self-hosted included)
are supported." Bitbucket/Gitea/other remotes are rejected here.
- Any other host → decide whether it is a self-hosted GitLab. GitLab's
`/api/v4/version` endpoint REQUIRES authentication by API design, so a
healthy instance answers a bare request with 401 — that 401 is POSITIVE
evidence (the endpoint exists and answers), not a failure. Probe order:
`curl -sSf https://<host>/api/v4/version`; a version JSON response OR a
401/GitLab-shaped error → classify as GitLab; connection refused or a
non-GitLab answer → STOP: "unsupported platform: only GitHub and GitLab
(self-hosted included) are supported." Bitbucket/Gitea/other remotes are
rejected here. Once classified, re-verify with `glab api version` after
step 2 auth passes. Platform `gitlab` (self-hosted), CLI `glab` pinned
to that host.
- When `origin` and a different `upstream` exist and point at different
repositories, ask the user ONCE which remote `/dag-auto` should bind to
and record the choice; otherwise bind `origin`.
Expand Down
2 changes: 2 additions & 0 deletions packages/core/test/plugin/command.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ describe("CommandPlugin.Plugin", () => {
})
expect(CommandPlugin.DagInitContent).toContain("$ARGUMENTS")
expect(CommandPlugin.DagInitContent).toContain("unsupported platform: only GitHub and GitLab")
expect(CommandPlugin.DagInitContent).toContain("401 is POSITIVE")
expect(CommandPlugin.DagInitContent).toContain("re-verify with `glab api version`")
expect(CommandPlugin.DagInitContent).toContain(".opencode/dag-init.json")
expect(CommandPlugin.DagInitContent).toContain("merge_policy")
expect(yield* command.get("dag-auto")).toMatchObject({
Expand Down
Loading