Fix(test-devtools-evm-foundry): remove lz-evm-v1 dependency that breaks external Foundry builds#1941
Open
Alison024 wants to merge 1 commit intoLayerZero-Labs:mainfrom
Open
Conversation
PR SummaryLow Risk Overview Updates Reviewed by Cursor Bugbot for commit 17a69cf. Bugbot is set up for automated code reviews on this repo. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@layerzerolabs/test-devtools-evm-foundryfails to compile in external Foundry projects (for example when dependencies are installed with Soldeer) because it imports a package that may not be installed transitively.This blocks users from running
forge build/forge testwhen following the LayerZero Foundry testing flow.Reproduction
forge buildorforge test.Observed error:
@layerzerolabs/lz-evm-v1-0.7/contracts/interfaces/ILayerZeroUltraLightNodeV2.solpackages/test-devtools-evm-foundry/contracts/mocks/DVNMock.solRoot Cause
DVNMock.solimportedILayerZeroUltraLightNodeV2from@layerzerolabs/lz-evm-v1-0.7.In consumer setups (especially with Soldeer), this deprecated LayerZero V1 package is often not installed, and the package does not need full V1 functionality anyway. As a result, consumers must add custom remappings or manually install an unnecessary/deprecated dependency.
What Changed
Updated
packages/test-devtools-evm-foundry/contracts/mocks/DVNMock.solILayerZeroUltraLightNodeV2from@layerzerolabs/lz-evm-v1-0.7DVNMock:withdrawNative(address payable,uint)updateHash(uint16,bytes32,uint,bytes32)Updated
packages/test-devtools-evm-foundry/package.json@layerzerolabs/lz-evm-v1-0.7from:devDependenciespeerDependenciesRebuilt package artifacts in:
packages/test-devtools-evm-foundry/artifacts/*Updated lockfile:
pnpm-lock.yamlWhy This Fix
test-devtools-evm-foundryeasier to consume in clean Foundry/Soldeer setups.Impact
Validation
@layerzerolabs/lz-evm-v1-0.7.References
ILayerZeroUltraLightNodeV2): raw.githubusercontent.com